qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()
Date: Wed, 23 Sep 2020 12:02:18 +0200	[thread overview]
Message-ID: <20200923100220.674903-3-philmd@redhat.com> (raw)
In-Reply-To: <20200923100220.674903-1-philmd@redhat.com>

Use the compiler built-in function to byte swap values,
as the compiler is clever and will fold constants.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/qemu/bswap.h | 30 ++++--------------------------
 1 file changed, 4 insertions(+), 26 deletions(-)

diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 8b01c38040c..d1a2f700f2a 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -27,32 +27,10 @@ static inline uint64_t bswap64(uint64_t x)
 {
     return bswap_64(x);
 }
-# else
-static inline uint16_t bswap16(uint16_t x)
-{
-    return (((x & 0x00ff) << 8) |
-            ((x & 0xff00) >> 8));
-}
-
-static inline uint32_t bswap32(uint32_t x)
-{
-    return (((x & 0x000000ffU) << 24) |
-            ((x & 0x0000ff00U) <<  8) |
-            ((x & 0x00ff0000U) >>  8) |
-            ((x & 0xff000000U) >> 24));
-}
-
-static inline uint64_t bswap64(uint64_t x)
-{
-    return (((x & 0x00000000000000ffULL) << 56) |
-            ((x & 0x000000000000ff00ULL) << 40) |
-            ((x & 0x0000000000ff0000ULL) << 24) |
-            ((x & 0x00000000ff000000ULL) <<  8) |
-            ((x & 0x000000ff00000000ULL) >>  8) |
-            ((x & 0x0000ff0000000000ULL) >> 24) |
-            ((x & 0x00ff000000000000ULL) >> 40) |
-            ((x & 0xff00000000000000ULL) >> 56));
-}
+#else
+# define bswap16(_x) __builtin_bswap16(_x)
+# define bswap32(_x) __builtin_bswap32(_x)
+# define bswap64(_x) __builtin_bswap64(_x)
 #endif /* ! CONFIG_MACHINE_BSWAP_H */
 
 static inline void bswap16s(uint16_t *s)
-- 
2.26.2



  parent reply	other threads:[~2020-09-23 10:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 10:02 [PATCH 0/4] qemu/bswap: Use compiler __builtin_bswap() Philippe Mathieu-Daudé
2020-09-23 10:02 ` [PATCH 1/4] qemu/bswap: Remove unused qemu_bswap_len() Philippe Mathieu-Daudé
2020-09-24 19:24   ` Richard Henderson
2020-09-23 10:02 ` Philippe Mathieu-Daudé [this message]
2020-09-24 19:25   ` [PATCH 2/4] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap() Richard Henderson
2020-09-23 10:02 ` [PATCH 3/4] qemu/bswap: Replace bswapXXs() " Philippe Mathieu-Daudé
2020-09-24 19:29   ` Richard Henderson
2020-09-23 10:02 ` [PATCH 4/4] qemu/bswap: Remove <byteswap.h> dependency Philippe Mathieu-Daudé
2020-09-23 10:16   ` Peter Maydell
2020-09-23 10:30     ` Philippe Mathieu-Daudé
2020-09-24 19:30       ` Richard Henderson
2020-09-24 19:33         ` Peter Maydell
2020-09-25  9:22           ` Philippe Mathieu-Daudé
2020-09-25 15:25             ` Richard Henderson
2020-09-24 19:29   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923100220.674903-3-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).