* [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash
@ 2020-09-18 15:35 Thomas Huth
2020-09-18 15:45 ` no-reply
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2020-09-18 15:35 UTC (permalink / raw)
To: qemu-devel, Kevin Wolf, Max Reitz; +Cc: Peter Maydell, qemu-block
macOS is shipped with a very old version of the bash (3.2), which
is currently not suitable for running the iotests anymore (e.g.
it is missing support for "readarray" which is used in the file
tests/qemu-iotests/common.filter). Add a check to skip the iotests
in this case - if someone still wants to run the iotests on macOS,
they can install a newer version from homebrew, for example.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
v2: Use LANG=C and "-q"
tests/check-block.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index a5a69060e1..f6b1bda7b9 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -46,6 +46,11 @@ if ! command -v bash >/dev/null 2>&1 ; then
exit 0
fi
+if LANG=C bash --version | grep -q 'GNU bash, version [123]' ; then
+ echo "bash version too old ==> Not running the qemu-iotests."
+ exit 0
+fi
+
if ! (sed --version | grep 'GNU sed') > /dev/null 2>&1 ; then
if ! command -v gsed >/dev/null 2>&1; then
echo "GNU sed not available ==> Not running the qemu-iotests."
--
2.18.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash
2020-09-18 15:35 [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash Thomas Huth
@ 2020-09-18 15:45 ` no-reply
2020-09-18 15:48 ` Daniel P. Berrangé
2020-09-23 15:23 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: no-reply @ 2020-09-18 15:45 UTC (permalink / raw)
To: thuth; +Cc: kwolf, peter.maydell, qemu-devel, qemu-block, mreitz
Patchew URL: https://patchew.org/QEMU/20200918153514.330705-1-thuth@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/20200918153514.330705-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash
2020-09-18 15:35 [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash Thomas Huth
2020-09-18 15:45 ` no-reply
@ 2020-09-18 15:48 ` Daniel P. Berrangé
2020-09-23 15:23 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2020-09-18 15:48 UTC (permalink / raw)
To: Thomas Huth; +Cc: Kevin Wolf, Peter Maydell, qemu-devel, qemu-block, Max Reitz
On Fri, Sep 18, 2020 at 05:35:14PM +0200, Thomas Huth wrote:
> macOS is shipped with a very old version of the bash (3.2), which
> is currently not suitable for running the iotests anymore (e.g.
> it is missing support for "readarray" which is used in the file
> tests/qemu-iotests/common.filter). Add a check to skip the iotests
> in this case - if someone still wants to run the iotests on macOS,
> they can install a newer version from homebrew, for example.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Use LANG=C and "-q"
>
> tests/check-block.sh | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash
2020-09-18 15:35 [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash Thomas Huth
2020-09-18 15:45 ` no-reply
2020-09-18 15:48 ` Daniel P. Berrangé
@ 2020-09-23 15:23 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2020-09-23 15:23 UTC (permalink / raw)
To: Thomas Huth; +Cc: Peter Maydell, qemu-devel, qemu-block, Max Reitz
Am 18.09.2020 um 17:35 hat Thomas Huth geschrieben:
> macOS is shipped with a very old version of the bash (3.2), which
> is currently not suitable for running the iotests anymore (e.g.
> it is missing support for "readarray" which is used in the file
> tests/qemu-iotests/common.filter). Add a check to skip the iotests
> in this case - if someone still wants to run the iotests on macOS,
> they can install a newer version from homebrew, for example.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-23 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 15:35 [PATCH v2] tests/check-block: Do not run the iotests with old versions of bash Thomas Huth
2020-09-18 15:45 ` no-reply
2020-09-18 15:48 ` Daniel P. Berrangé
2020-09-23 15:23 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).