Re: [PATCH v4 1/2] qemu/atomic: Update coding style to make checkpatch.pl happier

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Wed, Sep 23, 2020 at 05:19:00PM +0200, Philippe Mathieu-Daudé wrote:
> To limit the number of checkpatch errors in the next commit,
> clean coding style issues first.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> False positive:
> 
>  ERROR: Use of volatile is usually wrong, please add a comment
>  #11: FILE: include/qemu/atomic.h:328:
>  +#define atomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile *) (p))
> 
>  ERROR: Use of volatile is usually wrong, please add a comment
>  #12: FILE: include/qemu/atomic.h:329:
>  +#define atomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile *) (p)) = (i))
> ---
>  include/qemu/atomic.h | 9 +++++----
>  util/bitmap.c         | 3 ++-
>  util/rcu.c            | 6 ++++--
>  3 files changed, 11 insertions(+), 7 deletions(-)

I already sent a pull request with the patch that renames atomic.h, but
this patch can be rebased on top:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]