From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Chuan Zheng <zhengchuan@huawei.com>
Cc: berrange@redhat.com, zhang.zhanghailiang@huawei.com,
quintela@redhat.com, yuxiating@huawei.com, qemu-devel@nongnu.org,
xiexiangyou@huawei.com, alex.chen@huawei.com,
jinyan12@huawei.com
Subject: Re: [PATCH v4 0/6] *** Add Multifd support for TLS migration ***
Date: Thu, 24 Sep 2020 10:03:11 +0100 [thread overview]
Message-ID: <20200924090311.GA4980@work-vm> (raw)
In-Reply-To: <1600139042-104593-1-git-send-email-zhengchuan@huawei.com>
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> v3 -> v4:
> still use MigrationState field and save hostname in migration_tls_channel_connect
> remove MigrationState from MultiFDSendParams
>
> v2 -> v3:
> rebase patches on master
>
> v1 -> v2:
> fix memoryleak of MigrationState hostname
> add tls_hostname into MultiFDSendParams for handshake use
> fix function alignment
> squash Patch005 and Patch006
> add ioc into trace-events
>
> TLS migration could easily reach bottleneck of cpu because of encryption
> and decryption in migration thread.
> In our test, the tls migration could only reach 300MB/s under bandwidth
> of 500MB/s.
>
> Inspired by multifd, we add multifd support for tls migration to make fully
> use of given net bandwidth at the cost of multi-cpus and could reduce
> at most of 100% migration time with 4U16G test vm.
>
> Evaluate migration time of migration vm.
> The VM specifications for migration are as follows:
> - VM use 4-K page;
> - the number of VCPU is 4;
> - the total memory is 16Gigabit;
> - use 'mempress' tool to pressurize VM(mempress 4096 100);
> - migration flag is 73755 (8219 + 65536 (TLS)) vs 204827 (8219 + 65536 (TLS) + 131072(Multifd))
>
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> | | TLS | MultiFD + TLS (2 channel) |
> --------------------------------------------------------t---------------------------
> | mempress 1024 120 | 25.035s | 15.067s |
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> | mempress 1024 200 | 48.798s | 25.334s |
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Queued.
> Chuan Zheng (6):
> migration/tls: save hostname into MigrationState
> migration/tls: extract migration_tls_client_create for common-use
> migration/tls: add tls_hostname into MultiFDSendParams
> migration/tls: extract cleanup function for common-use
> migration/tls: add support for multifd tls-handshake
> migration/tls: add trace points for multifd-tls
>
> migration/channel.c | 1 +
> migration/migration.c | 1 +
> migration/migration.h | 5 ++
> migration/multifd.c | 124 +++++++++++++++++++++++++++++++++++++++++++------
> migration/multifd.h | 2 +
> migration/tls.c | 28 +++++++----
> migration/tls.h | 6 +++
> migration/trace-events | 4 ++
> 8 files changed, 149 insertions(+), 22 deletions(-)
>
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2020-09-24 9:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 3:03 [PATCH v4 0/6] *** Add Multifd support for TLS migration *** Chuan Zheng
2020-09-15 3:03 ` [PATCH v4 1/6] migration/tls: save hostname into MigrationState Chuan Zheng
2020-09-15 8:21 ` Daniel P. Berrangé
2020-09-15 3:03 ` [PATCH v4 2/6] migration/tls: extract migration_tls_client_create for common-use Chuan Zheng
2020-09-15 3:03 ` [PATCH v4 3/6] migration/tls: add tls_hostname into MultiFDSendParams Chuan Zheng
2020-09-15 8:21 ` Daniel P. Berrangé
2020-09-15 3:04 ` [PATCH v4 4/6] migration/tls: extract cleanup function for common-use Chuan Zheng
2020-09-15 3:04 ` [PATCH v4 5/6] migration/tls: add support for multifd tls-handshake Chuan Zheng
2020-09-15 3:04 ` [PATCH v4 6/6] migration/tls: add trace points for multifd-tls Chuan Zheng
2020-09-24 9:03 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924090311.GA4980@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.chen@huawei.com \
--cc=berrange@redhat.com \
--cc=jinyan12@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=yuxiating@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).