From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C228C4727D for ; Thu, 24 Sep 2020 07:13:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2811C206C9 for ; Thu, 24 Sep 2020 07:13:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HVK9eLJ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2811C206C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLLR8-0002V0-42 for qemu-devel@archiver.kernel.org; Thu, 24 Sep 2020 03:13:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLLQZ-000251-VK for qemu-devel@nongnu.org; Thu, 24 Sep 2020 03:12:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLLQY-0006SW-80 for qemu-devel@nongnu.org; Thu, 24 Sep 2020 03:12:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600931545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgzRCKPLUh4+P8tXQ0k9+KMV0qeuMv/FcZMBJTr2/ic=; b=HVK9eLJ8CgB5YPGppxXbL2Zhhpsa6n5EUo8IAARIhtNaIB/VpiGG5O51DEukNWcA+Wb7OK db2tIIK2TtNn2PN1RyjT7EdAjPflCUIBPjZrlS9k9BZK9fea9LiJD3uduPBAds7JLGTqXP I8/hmXwyt/9cfP2b2Cmd+F5yq4ktlL0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-1yCUx6p6OemxMQiFQkEnOg-1; Thu, 24 Sep 2020 03:12:21 -0400 X-MC-Unique: 1yCUx6p6OemxMQiFQkEnOg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7163D427C2; Thu, 24 Sep 2020 07:12:20 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F76E7368A; Thu, 24 Sep 2020 07:12:16 +0000 (UTC) Date: Thu, 24 Sep 2020 09:12:14 +0200 From: Igor Mammedov To: Laszlo Ersek Subject: Re: [PATCH v6 00/11] x86: fix cpu hotplug with secure boot Message-ID: <20200924091214.3d9b8bfd@redhat.com> In-Reply-To: References: <20200923094650.1301166-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 23:02:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, ankur.a.arora@oracle.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 23 Sep 2020 18:44:50 +0200 Laszlo Ersek wrote: > On 09/23/20 11:46, Igor Mammedov wrote: > > v6: > > - [9/10] Add comment explaining why while_ctx2 restarts from the last processed CPU. > > - rebase on top of current master, due to non trivial conflict > > caused by microvm series, which moved/renamed pc_cpu_pre_plug() > > So, I went back to my local branch where I had applied your v5, *plus* > the comment fixup ("[PATCH v5 9/10] fixup! x68: acpi: trigger SMI before > sending hotplug Notify event to OSPM") on top. I rebased that branch to > its *same* base commit, only squashing the comment fixup into patch#9. > > Then I applied your v6 series on top of current master, using a > different (new) local branch. > > Then I ran git-range-diff on these two local branches. > > In patches 6, 7, 8, and 9, you've picked up my feedback tags from the v5 > review session; that's good, there was nothing else to do. > > There is a trivial difference in patch 2 -- trivial to review, that is; > I'm not saying that it's so trivial that git-rebase should have coped > with it automatically on your end. Here's the git-range-diff output: > > > 2: e606a75432a8 ! 2: 94702d2e3125 x86: cpuhp: prevent guest crash on CPU hotplug when broadcast SMI is in use > > @@ -12,7 +12,7 @@ > > Signed-off-by: Igor Mammedov > > Reviewed-by: Laszlo Ersek > > Tested-by: Laszlo Ersek > > - Message-Id: <20200907112348.530921-3-imammedo@redhat.com> > > + Message-Id: <20200923094650.1301166-3-imammedo@redhat.com> > > > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > > --- a/hw/acpi/ich9.c > > @@ -40,17 +40,17 @@ > > > > void ich9_pm_device_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, > > > > -diff --git a/hw/i386/pc.c b/hw/i386/pc.c > > ---- a/hw/i386/pc.c > > -+++ b/hw/i386/pc.c > > +diff --git a/hw/i386/x86.c b/hw/i386/x86.c > > +--- a/hw/i386/x86.c > > ++++ b/hw/i386/x86.c > > @@ > > return; > > } > > > > -+ if (pcms->acpi_dev) { > > ++ if (x86ms->acpi_dev) { > > + Error *local_err = NULL; > > + > > -+ hotplug_handler_pre_plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, > > ++ hotplug_handler_pre_plug(HOTPLUG_HANDLER(x86ms->acpi_dev), dev, > > + &local_err); > > + if (local_err) { > > + error_propagate(errp, local_err); > > Meaning that, in v6, you had to refer to "x86ms", rather than to "pcms", > and that the code had to be introduced in a different file / function. > > The need for that originates from 0cca1a918b85 ("x86: move cpu hotplug > from pc to x86", 2020-09-17). I should have added this commit to change log to spare you trouble figuring out what exactly has changed. > > It looks innocent enough, but I should still retest patch#2. I'll report > back under that patch in this series. > > Thanks > Laszlo