From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B16DC4363D for ; Thu, 24 Sep 2020 10:34:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A946223741 for ; Thu, 24 Sep 2020 10:34:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YOY6QPiM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A946223741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLOaL-00052l-RQ for qemu-devel@archiver.kernel.org; Thu, 24 Sep 2020 06:34:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLNZu-0002pc-Cl for qemu-devel@nongnu.org; Thu, 24 Sep 2020 05:30:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLNZs-00073d-BH for qemu-devel@nongnu.org; Thu, 24 Sep 2020 05:30:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600939811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iW0pCq6dDvD3vZp/QFwiujdBewUI4+ZohpMyMTnRyyc=; b=YOY6QPiMiEWvVcoDWDqeFuq6r8e0ZbecCWIB12OPriENneR+rDdD7IYukhKh2/xLkmm3sT 05iqlXZtVF1n8n96qAWe3hmdNLpJ9OHhNVoze0QYyIxoefogaseit5uVM1Y/dSnenTnBN+ RJ/qG00X8rbYxIx0aoSfXDP8lnuBjC4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-zwezOnSpMU6-BuqtnaTlzw-1; Thu, 24 Sep 2020 05:30:10 -0400 X-MC-Unique: zwezOnSpMU6-BuqtnaTlzw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E94D764092; Thu, 24 Sep 2020 09:30:08 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1164755786; Thu, 24 Sep 2020 09:30:01 +0000 (UTC) Date: Thu, 24 Sep 2020 11:30:00 +0200 From: Igor Mammedov To: Julia Suvorova Subject: Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35 Message-ID: <20200924113000.17863350@redhat.com> In-Reply-To: <20200924070013.165026-1-jusual@redhat.com> References: <20200924070013.165026-1-jusual@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 23:02:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ani Sinha , qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 24 Sep 2020 09:00:06 +0200 Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > This way maintainers can decide which way to choose without breaking > the patch set. > > With the feature disabled Q35 falls back to the native hot-plug. > > Pros > * no racy behavior during boot (see 110c477c2ed) > * eject is possible - according to PCIe spec, attention button > press should lead to power off, and then the adapter should be > removed manually. As there is no power down state exists in QEMU, > we cannot distinguish between an eject and a power down > request. if I recall right, you had a idea about keeping pending removal request to distinguish between eject and poweroff (i.e. eject if mgmt asked for removal and otherwise it could be poweroff|nop) Why it didn't work out in the end? > * no delay during deleting - after the actual power off software > must wait at least 1 second before indicating about it. This case > is quite important for users, it even has its own bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1594168 > * no timer-based behavior - in addition to the previous example, > the attention button has a 5-second waiting period, during which > the operation can be canceled with a second press. While this > looks fine for manual button control, automation will result in > the need to queue or drop events, and the software receiving > events in all sort of unspecified combinations of attention/power > indicator states, which is racy and uppredictable. > * fixes: > * https://bugzilla.redhat.com/show_bug.cgi?id=1752465 > * https://bugzilla.redhat.com/show_bug.cgi?id=1690256 > > Cons: > * lose per-port control over hot-plug (can be resolved) > * no access to possible features presented in slot capabilities > (this is only surprise removal AFAIK) > > v3: > * drop change of _OSC to allow SHPC on hotplugged bridges > * use 'acpi-root-pci-hotplug' > * add migration states [Igor] > * minor style changes > > v2: > * new ioport range for acpiphp [Gerd] > * drop find_pci_host() [Igor] > * explain magic numbers in _OSC [Igor] > * drop build_q35_pci_hotplug() wrapper [Igor] > > Julia Suvorova (7): > hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35 > hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35 > hw/pci/pcie: Do not initialize slot capability if acpihp is used > hw/acpi/ich9: Enable ACPI PCI hot-plug > bios-tables-test: Allow changes in DSDT ACPI tables > hw/acpi/ich9: Set ACPI PCI hot-plug as default > bios-tables-test: Update golden binaries > > hw/i386/acpi-build.h | 7 ++++ > include/hw/acpi/ich9.h | 5 +++ > include/hw/acpi/pcihp.h | 3 +- > hw/acpi/ich9.c | 67 ++++++++++++++++++++++++++++++ > hw/acpi/pcihp.c | 16 ++++--- > hw/acpi/piix4.c | 4 +- > hw/i386/acpi-build.c | 31 ++++++++------ > hw/i386/pc.c | 1 + > hw/pci/pcie.c | 16 +++++++ > tests/data/acpi/q35/DSDT | Bin 7678 -> 7950 bytes > tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 9274 bytes > tests/data/acpi/q35/DSDT.bridge | Bin 7695 -> 9865 bytes > tests/data/acpi/q35/DSDT.cphp | Bin 8141 -> 8413 bytes > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9331 -> 9603 bytes > tests/data/acpi/q35/DSDT.ipmibt | Bin 7753 -> 8025 bytes > tests/data/acpi/q35/DSDT.memhp | Bin 9037 -> 9309 bytes > tests/data/acpi/q35/DSDT.mmio64 | Bin 8808 -> 9080 bytes > tests/data/acpi/q35/DSDT.numamem | Bin 7684 -> 7956 bytes > tests/data/acpi/q35/DSDT.tis | Bin 8283 -> 8555 bytes > 19 files changed, 129 insertions(+), 21 deletions(-) >