From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Coiby Xu <coiby.xu@gmail.com>, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v2 00/13] block/export: convert vhost-user-blk-server to block exports API
Date: Thu, 24 Sep 2020 16:15:36 +0100 [thread overview]
Message-ID: <20200924151549.913737-1-stefanha@redhat.com> (raw)
v2:
* Replace unix-socket=str with addr=SocketAddress for consistency with NBD and
fd passing support. The new syntax is:
--export vhost-user-blk,addr.type=unix,addr.path=/tmp/vhost-user-blk.sock,...
* Make addr=SocketAddress mandatory instead of optional [Markus]
* Update test-vhost-user-blk.c to use new syntax
* Add patch moving vhost-user-server.h to include/
* Add patch to use libvhost-user.a instead of compiling it multiple times
This patch series converts Coiby Xu's vhost-user-blk-server from a QOM object
to the block exports API. The block exports API provides a standard QMP and
command-line interface for managing block exports (NBD, FUSE, vhost-user-blk,
etc). A fair amount of init/shutdown code is removed because the block exports
API already takes care of that functionality.
Most of the patches are vhost-user-blk-server cleanups.
The syntax for launching qemu-storage-daemon is:
$ qemu-storage-daemon \
--blockdev file,node-name=drive0,filename=test.img \
--export vhost-user-blk,node-name=drive0,id=export0,writable=on,addr.type=unix,addr.path=/tmp/vhost-user-blk.sock
QEMU can connect to the vhost-user-blk export like this:
$ qemu-system-x86_64 \
-M accel=kvm,memory-backend=mem \
-m 1G \
-object memory-backend-memfd,size=1G,id=mem \
-cpu host \
-chardev socket,path=/tmp/vhost-user-blk.sock,id=char0 \
-device vhost-user-blk-pci,chardev=char0
Based-on: 20200918080912.321299-1-coiby.xu@gmail.com ("[PATCH v10 0/7] vhost-user block device backend implementation")
Based-on: 20200907182011.521007-1-kwolf@redhat.com ("[PATCH 00/29] block/export: Add infrastructure and QAPI for block exports")
Stefan Hajnoczi (13):
block/export: shorten serial string to fit
util/vhost-user-server: s/fileds/fields/ typo fix
util/vhost-user-server: drop unnecessary QOM cast
util/vhost-user-server: drop unnecessary watch deletion
block/export: consolidate request structs into VuBlockReq
util/vhost-user-server: drop unused DevicePanicNotifier
util/vhost-user-server: fix memory leak in vu_message_read()
util/vhost-user-server: check EOF when reading payload
util/vhost-user-server: rework vu_client_trip() coroutine lifecycle
block/export: report flush errors
block/export: convert vhost-user-blk server to block export API
util/vhost-user-server: move header to include/
util/vhost-user-server: use static library in meson.build
MAINTAINERS | 4 +-
qapi/block-export.json | 21 +-
block/export/vhost-user-blk-server.h | 23 +-
{util => include/qemu}/vhost-user-server.h | 32 +-
block/export/export.c | 8 +-
block/export/vhost-user-blk-server.c | 525 ++++++---------------
tests/qtest/vhost-user-blk-test.c | 2 +-
util/vhost-user-server.c | 334 ++++++-------
block/export/meson.build | 1 +
block/meson.build | 1 -
contrib/libvhost-user/meson.build | 1 +
meson.build | 6 +-
tests/qtest/meson.build | 2 +-
util/meson.build | 4 +-
14 files changed, 376 insertions(+), 588 deletions(-)
rename {util => include/qemu}/vhost-user-server.h (72%)
--
2.26.2
next reply other threads:[~2020-09-24 15:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 15:15 Stefan Hajnoczi [this message]
2020-09-24 15:15 ` [PATCH v2 01/13] block/export: shorten serial string to fit Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 02/13] util/vhost-user-server: s/fileds/fields/ typo fix Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 03/13] util/vhost-user-server: drop unnecessary QOM cast Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 04/13] util/vhost-user-server: drop unnecessary watch deletion Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 05/13] block/export: consolidate request structs into VuBlockReq Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 06/13] util/vhost-user-server: drop unused DevicePanicNotifier Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 07/13] util/vhost-user-server: fix memory leak in vu_message_read() Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 08/13] util/vhost-user-server: check EOF when reading payload Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 09/13] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 10/13] block/export: report flush errors Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 11/13] block/export: convert vhost-user-blk server to block export API Stefan Hajnoczi
2020-09-30 5:28 ` Markus Armbruster
2020-09-30 9:45 ` Stefan Hajnoczi
2020-09-30 14:33 ` Markus Armbruster
2020-10-01 15:25 ` Stefan Hajnoczi
2020-10-02 5:20 ` Markus Armbruster
2020-10-08 16:02 ` Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 12/13] util/vhost-user-server: move header to include/ Stefan Hajnoczi
2020-09-24 15:15 ` [PATCH v2 13/13] util/vhost-user-server: use static library in meson.build Stefan Hajnoczi
2020-10-09 10:18 ` [PATCH v2 00/13] block/export: convert vhost-user-blk-server to block exports API Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924151549.913737-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=coiby.xu@gmail.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).