From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FDEC4363D for ; Fri, 25 Sep 2020 09:19:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06F81206E5 for ; Fri, 25 Sep 2020 09:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q2vT9869" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06F81206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLjsq-0000rq-1w for qemu-devel@archiver.kernel.org; Fri, 25 Sep 2020 05:19:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLjrk-00004z-Q6 for qemu-devel@nongnu.org; Fri, 25 Sep 2020 05:18:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLjrj-00008U-80 for qemu-devel@nongnu.org; Fri, 25 Sep 2020 05:18:08 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601025486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zdNyfj6okx2W0CrZGKgNIYWl+PLE9oMxshn2W1/Qz+k=; b=Q2vT9869rer+gbOLhliJeC0GXNuBPt2hSyb5c3k2omDDn/J3wnQjZrxtrGehtK18Be+UbH p+tP67Azow2WCdF5vUKxNo6k7EelzTA09kAbAleVaxZY6/Na3Ctc6fsRSNLWNTlGIMI1uF sNbmhCpYxB/cfEj9ThFS0s13SBcUOL0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-HqoZG-fBNeqlt1m3Ax7ZHg-1; Fri, 25 Sep 2020 05:18:02 -0400 X-MC-Unique: HqoZG-fBNeqlt1m3Ax7ZHg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54F131091068; Fri, 25 Sep 2020 09:18:00 +0000 (UTC) Received: from gondolin (ovpn-112-192.ams2.redhat.com [10.36.112.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 083AD5D9F1; Fri, 25 Sep 2020 09:17:48 +0000 (UTC) Date: Fri, 25 Sep 2020 11:17:46 +0200 From: Cornelia Huck To: Matthew Rosato Subject: Re: [PATCH 3/7] s390x/pci: create a header dedicated to PCI CLP Message-ID: <20200925111746.2e3bf28f.cohuck@redhat.com> In-Reply-To: <1600529672-10243-4-git-send-email-mjrosato@linux.ibm.com> References: <1600529672-10243-1-git-send-email-mjrosato@linux.ibm.com> <1600529672-10243-4-git-send-email-mjrosato@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/25 02:48:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, kvm@vger.kernel.org, pmorel@linux.ibm.com, david@redhat.com, schnelle@linux.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, pasic@linux.ibm.com, borntraeger@de.ibm.com, alex.williamson@redhat.com, mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 19 Sep 2020 11:34:28 -0400 Matthew Rosato wrote: > From: Pierre Morel > > To have a clean separation between s390-pci-bus.h and s390-pci-inst.h > headers we export the PCI CLP instructions in a dedicated header. > > Signed-off-by: Pierre Morel > Signed-off-by: Matthew Rosato > --- > hw/s390x/s390-pci-bus.h | 1 + > hw/s390x/s390-pci-clp.h | 211 +++++++++++++++++++++++++++++++++++++++++++++++ > hw/s390x/s390-pci-inst.h | 196 ------------------------------------------- > 3 files changed, 212 insertions(+), 196 deletions(-) > create mode 100644 hw/s390x/s390-pci-clp.h Looks sane; but I wonder whether we should move the stuff under include/hw/s390x/.