qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Collin Walling <walling@linux.ibm.com>,
	frankja@linux.ibm.com, mst@redhat.com, david@redhat.com,
	qemu-devel@nongnu.org, pasic@linux.ibm.com,
	borntraeger@de.ibm.com, qemu-s390x@nongnu.org, thuth@redhat.com,
	pbonzini@redhat.com, sumanthk@linux.ibm.com,
	mihajlov@linux.ibm.com, rth@twiddle.net
Subject: Re: [PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318
Date: Fri, 25 Sep 2020 17:32:05 +0200	[thread overview]
Message-ID: <20200925173205.288d877b@ibm-vm> (raw)
In-Reply-To: <20200925171855.670bd93a.cohuck@redhat.com>

On Fri, 25 Sep 2020 17:18:55 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> On Fri, 25 Sep 2020 11:13:49 -0400
> Collin Walling <walling@linux.ibm.com> wrote:
> 
> > On 9/16/20 1:15 PM, Collin Walling wrote:  
> > > On 9/16/20 11:53 AM, Cornelia Huck wrote:
> > > 
> > > [...]
> > >     
> > >>>    
> > >>
> > >> Thanks, applied.
> > >>
> > >>    
> > > 
> > > Thanks Conny.
> > > 
> > > Much appreciated for everyone's patience and review. The only
> > > thing I'd like to hold out on for now is for someone to take a
> > > peek at patch #3 with respect to the protected virtualization
> > > stuff. I don't know too much about it, honestly, and I want to
> > > ensure that dynamically allocating memory for the SCCB makes
> > > sense there. The alternative would be to allocate a static 4K for
> > > the work_sccb. 
> > 
> > I had someone take a look at the patch for PV and was told
> > everything looks sane. Since the patches have already been applied,
> > it seems like it's too late to add a reviewed-by from someone?  
> 
> Have the reviewer reply with their R-b, and I'll happily add it, as I
> rebase s390-next before doing a pull req anyway :)

well it was me :)

you can add a 

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

for the first 6 patches, and an

Acked-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

for the last one


thanks!



  reply	other threads:[~2020-09-25 15:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 19:44 [PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318 Collin Walling
2020-09-15 19:44 ` [PATCH v6 1/8] s390/sclp: get machine once during read scp/cpu info Collin Walling
2020-09-15 19:44 ` [PATCH v6 2/8] s390/sclp: rework sclp boundary checks Collin Walling
2020-09-16  7:10   ` Thomas Huth
2020-09-16 16:12     ` Collin Walling
2020-09-15 19:44 ` [PATCH v6 3/8] s390/sclp: read sccb from mem based on provided length Collin Walling
2020-09-16  8:00   ` Thomas Huth
2020-09-15 19:44 ` [PATCH v6 4/8] s390/sclp: check sccb len before filling in data Collin Walling
2020-09-15 19:44 ` [PATCH v6 5/8] s390/sclp: use cpu offset to locate cpu entries Collin Walling
2020-09-15 19:44 ` [PATCH v6 6/8] s390/sclp: add extended-length sccb support for kvm guest Collin Walling
2020-09-15 19:44 ` [PATCH v6 7/8] s390/kvm: header sync for diag318 Collin Walling
2020-09-16 15:52   ` Cornelia Huck
2020-09-16 16:11     ` Collin Walling
2020-09-15 19:44 ` [PATCH v6 8/8] s390: guest support for diagnose 0x318 Collin Walling
2020-09-16  8:11   ` Thomas Huth
2020-09-16  8:21     ` David Hildenbrand
2020-09-15 19:57 ` [PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318 no-reply
2020-09-16  6:37   ` Cornelia Huck
2020-09-16 15:53 ` Cornelia Huck
2020-09-16 17:15   ` Collin Walling
2020-09-25 15:13     ` Collin Walling
2020-09-25 15:18       ` Cornelia Huck
2020-09-25 15:32         ` Claudio Imbrenda [this message]
2020-09-25 15:43           ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925173205.288d877b@ibm-vm \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=mihajlov@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sumanthk@linux.ibm.com \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).