From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: spice-devel@lists.freedesktop.org,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH v3 4/6] spice: remove the single monitor config logic
Date: Sun, 27 Sep 2020 18:57:49 +0400 [thread overview]
Message-ID: <20200927145751.365446-5-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20200927145751.365446-1-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Introduced in commit 9c956e646178fee8c14ce7dfae5a9d7cb901876c ("spice:
prepare for upcoming spice-server change"), the new logic never
materialized in the spice server source tree. Let's remove it for now,
until it actually changes in Spice.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/spice-display.c | 26 ++++----------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 625d9232b9..b304c13149 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -674,28 +674,10 @@ static int interface_client_monitors_config(QXLInstance *sin,
info = *dpy_get_ui_info(ssd->dcl.con);
- if (mc->num_of_monitors == 1) {
- /*
- * New spice-server version which filters the list of monitors
- * to only include those that belong to our display channel.
- *
- * single-head configuration (where filtering doesn't matter)
- * takes this code path too.
- */
- info.width = mc->monitors[0].width;
- info.height = mc->monitors[0].height;
- } else {
- /*
- * Old spice-server which gives us all monitors, so we have to
- * figure ourself which entry we need. Array index is the
- * channel_id, which is the qemu console index, see
- * qemu_spice_add_display_interface().
- */
- head = qemu_console_get_index(ssd->dcl.con);
- if (mc->num_of_monitors > head) {
- info.width = mc->monitors[head].width;
- info.height = mc->monitors[head].height;
- }
+ head = qemu_console_get_index(ssd->dcl.con);
+ if (mc->num_of_monitors > head) {
+ info.width = mc->monitors[head].width;
+ info.height = mc->monitors[head].height;
}
trace_qemu_spice_ui_info(ssd->qxl.id, info.width, info.height);
--
2.26.2
next prev parent reply other threads:[~2020-09-27 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 14:57 [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 1/6] edid: fix physical display size computation marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 2/6] edid: use physical dimensions if available marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 3/6] ui: add getter for UIInfo marcandre.lureau
2020-09-27 14:57 ` marcandre.lureau [this message]
2020-09-27 14:57 ` [PATCH v3 5/6] spice: get monitors physical dimension marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 6/6] virtio-gpu: set physical dimensions for EDID marcandre.lureau
2020-09-27 15:43 ` [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu no-reply
2020-09-29 7:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927145751.365446-5-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).