qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
	"Li Qiang" <liq3ea@163.com>, "Laurent Vivier" <laurent@vivier.eu>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 3/8] virtio: vdpa: omit check return of g_malloc
Date: Mon, 28 Sep 2020 11:15:57 +0200	[thread overview]
Message-ID: <20200928091602.383870-4-laurent@vivier.eu> (raw)
In-Reply-To: <20200928091602.383870-1-laurent@vivier.eu>

From: Li Qiang <liq3ea@163.com>

If g_malloc fails, the application will be terminated.
No need to check the return value of g_malloc.

Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200819144309.67579-1-liq3ea@163.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/virtio/vhost-vdpa.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index e123837a55de..97f4b2e353ab 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -320,10 +320,8 @@ static int vhost_vdpa_set_config(struct vhost_dev *dev, const uint8_t *data,
     struct vhost_vdpa_config *config;
     int ret;
     unsigned long config_size = offsetof(struct vhost_vdpa_config, buf);
+
     config = g_malloc(size + config_size);
-    if (config == NULL) {
-        return -1;
-    }
     config->off = offset;
     config->len = size;
     memcpy(config->buf, data, size);
@@ -340,9 +338,6 @@ static int vhost_vdpa_get_config(struct vhost_dev *dev, uint8_t *config,
     int ret;
 
     v_config = g_malloc(config_len + config_size);
-    if (v_config == NULL) {
-        return -1;
-    }
     v_config->len = config_len;
     v_config->off = 0;
     ret = vhost_vdpa_call(dev, VHOST_VDPA_GET_CONFIG, v_config);
-- 
2.26.2



  parent reply	other threads:[~2020-09-28  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  9:15 [PULL 0/8] Trivial branch for 5.2 patches Laurent Vivier
2020-09-28  9:15 ` [PULL 1/8] vhost-vdpa: fix indentation in vdpa_ops Laurent Vivier
2020-09-28  9:15 ` [PULL 2/8] meson: fix static flag summary Laurent Vivier
2020-09-28  9:15 ` Laurent Vivier [this message]
2020-09-28  9:15 ` [PULL 4/8] Add *.pyc back to the .gitignore file Laurent Vivier
2020-09-28  9:15 ` [PULL 5/8] vhost-vdpa: remove useless variable Laurent Vivier
2020-09-28  9:16 ` [PULL 6/8] timer: Fix timer_mod_anticipate() documentation Laurent Vivier
2020-09-28  9:16 ` [PULL 7/8] migration/multifd: Remove superfluous semicolons Laurent Vivier
2020-09-28  9:16 ` [PULL 8/8] docs/system/deprecated: Move lm32 and unicore32 to the right section Laurent Vivier
2020-09-28 15:48 ` [PULL 0/8] Trivial branch for 5.2 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928091602.383870-4-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alex.bennee@linaro.org \
    --cc=liq3ea@163.com \
    --cc=lvivier@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).