qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
	"Li Qiang" <liq3ea@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 5/8] vhost-vdpa: remove useless variable
Date: Mon, 28 Sep 2020 11:15:59 +0200	[thread overview]
Message-ID: <20200928091602.383870-6-laurent@vivier.eu> (raw)
In-Reply-To: <20200928091602.383870-1-laurent@vivier.eu>

From: Laurent Vivier <lvivier@redhat.com>

in vhost_vdpa_listener_region_del(), try_unmap is always true and so,
vhost_vdpa_dma_unmap() is always called. We can remove the variable

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200920152024.860172-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/virtio/vhost-vdpa.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 97f4b2e353ab..aedc52c4d791 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -153,7 +153,6 @@ static void vhost_vdpa_listener_region_del(MemoryListener *listener,
     hwaddr iova;
     Int128 llend, llsize;
     int ret;
-    bool try_unmap = true;
 
     if (vhost_vdpa_listener_skipped_section(section)) {
         return;
@@ -176,11 +175,9 @@ static void vhost_vdpa_listener_region_del(MemoryListener *listener,
 
     llsize = int128_sub(llend, int128_make64(iova));
 
-    if (try_unmap) {
-        ret = vhost_vdpa_dma_unmap(v, iova, int128_get64(llsize));
-        if (ret) {
-            error_report("vhost_vdpa dma unmap error!");
-        }
+    ret = vhost_vdpa_dma_unmap(v, iova, int128_get64(llsize));
+    if (ret) {
+        error_report("vhost_vdpa dma unmap error!");
     }
 
     memory_region_unref(section->mr);
-- 
2.26.2



  parent reply	other threads:[~2020-09-28  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  9:15 [PULL 0/8] Trivial branch for 5.2 patches Laurent Vivier
2020-09-28  9:15 ` [PULL 1/8] vhost-vdpa: fix indentation in vdpa_ops Laurent Vivier
2020-09-28  9:15 ` [PULL 2/8] meson: fix static flag summary Laurent Vivier
2020-09-28  9:15 ` [PULL 3/8] virtio: vdpa: omit check return of g_malloc Laurent Vivier
2020-09-28  9:15 ` [PULL 4/8] Add *.pyc back to the .gitignore file Laurent Vivier
2020-09-28  9:15 ` Laurent Vivier [this message]
2020-09-28  9:16 ` [PULL 6/8] timer: Fix timer_mod_anticipate() documentation Laurent Vivier
2020-09-28  9:16 ` [PULL 7/8] migration/multifd: Remove superfluous semicolons Laurent Vivier
2020-09-28  9:16 ` [PULL 8/8] docs/system/deprecated: Move lm32 and unicore32 to the right section Laurent Vivier
2020-09-28 15:48 ` [PULL 0/8] Trivial branch for 5.2 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928091602.383870-6-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=liq3ea@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).