From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C59BC2D0A8 for ; Mon, 28 Sep 2020 14:41:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B88202076A for ; Mon, 28 Sep 2020 14:41:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QgnR2Lyh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B88202076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMuKr-000266-JY for qemu-devel@archiver.kernel.org; Mon, 28 Sep 2020 10:41:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMuJP-0001Wy-Si for qemu-devel@nongnu.org; Mon, 28 Sep 2020 10:39:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kMuJN-0005gW-MK for qemu-devel@nongnu.org; Mon, 28 Sep 2020 10:39:31 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601303968; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ahuyk5kg4JClss0YP+ND4k/voPI942pTa4w2e0eYxc=; b=QgnR2LyhQcpRAgNibCgb2b1ejBGRuR2Gjl/2oIb8kDudrDB2jwuG4LwZe01YMebDCeS9Jw QclMwyFgrTTlVH1vIZFasuy4CiLUxLaVIa2fB6wO0inV9fUPuMMdz3hxGf27v1djP6MEW8 oa3pRStoi0taS/Lo2mP05uIsZ7sSJjE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-p4GEg8oSNZCgVW2qtYnUvQ-1; Mon, 28 Sep 2020 10:39:20 -0400 X-MC-Unique: p4GEg8oSNZCgVW2qtYnUvQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D99A1835A00; Mon, 28 Sep 2020 14:39:19 +0000 (UTC) Received: from redhat.com (ovpn-114-24.ams2.redhat.com [10.36.114.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BF235C1BB; Mon, 28 Sep 2020 14:39:17 +0000 (UTC) Date: Mon, 28 Sep 2020 15:39:14 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Subject: Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' Message-ID: <20200928143914.GK2230076@redhat.com> References: <20200928125859.734287-1-philmd@redhat.com> <20200928125859.734287-2-philmd@redhat.com> <20200928140448.GH2230076@redhat.com> <20200928142322.GJ2230076@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/28 03:29:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , Richard Henderson , QEMU Developers , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 28, 2020 at 03:32:45PM +0100, Peter Maydell wrote: > On Mon, 28 Sep 2020 at 15:23, Daniel P. Berrangé wrote: > > > > On Mon, Sep 28, 2020 at 03:14:45PM +0100, Peter Maydell wrote: > > > On Mon, 28 Sep 2020 at 15:06, Daniel P. Berrangé wrote: > > > > I think this can be simplified even more by using GLib's macros > > > > > > > > #define GCC_FMT_ATTR(n, m) G_GNUC_PRINTF(n, m) > > > > > > At least on my system G_GNUC_PRINTF() expands to > > > __format__(__printf__,...), not gnu_printf, so it is > > > not quite what we want. (The difference is that on Windows > > > hosts we still want to mark up our our logging functions as > > > taking the glibc style format handling, not whatever the > > > MS C library format escapes happen to be.) > > > At a minimum you'd need to keep in the "on Windows, > > > redefine __printf__ to __gnu_printf__" logic. > > > > > > See also commit 95df51a4a02a853. > > > > Oh, that's a bug in old GLib versions. I thought we had a new enough > > min to avoid that problem, but i guess not after all. > > Looks like the implementation changed 2 years ago: > https://gitlab.gnome.org/GNOME/glib/-/commit/98a0ab929d8c59ee27e5f470f11d077bb6a56749 > not sure which glib version that would correspond to. Looks like 2.58.0, which is still a fair bit newer than our 2.48 min. NB, only the macro changed - they were using GNU printf impl for many many years before that but simply had the wrong macro definition We can just sacrifice -Wformat checking for Windows builds when using old GLib. People building natively on Windows with MSys probably have brand new GLib, and those using Fedora mingw / Debian MXE also have pretty new GLib. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|