From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PULL 1/1] Revert "migration: Properly destroy variables on incoming side"
Date: Mon, 28 Sep 2020 11:51:06 -0400 [thread overview]
Message-ID: <20200928155106.GC5904@xz-x1> (raw)
In-Reply-To: <20200928152024.209894-2-dgilbert@redhat.com>
On Mon, Sep 28, 2020 at 04:20:24PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This reverts commit c02039a6f3730ddcf683a0ba9a175688c6db71a0.
>
> This is breaking test 068 that does a loadvm twice.
This is exactly something I'm afraid of happening... :-(
Though for the long term in the future, ideally maybe we should just forbid
loadvm for more than once (restarting a QEMU instance won't hurt, afaict, or we
really need to be careful on the whole loadvm path, I'm not sure whether
there's any other spots that we didn't notice that won't allow reentrance), or
we should provide some reset helper, so that we won't only destroy partially in
the destroy helper.
--
Peter Xu
next prev parent reply other threads:[~2020-09-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 15:20 [PULL 0/1] migration queue Dr. David Alan Gilbert (git)
2020-09-28 15:20 ` [PULL 1/1] Revert "migration: Properly destroy variables on incoming side" Dr. David Alan Gilbert (git)
2020-09-28 15:51 ` Peter Xu [this message]
2020-09-29 10:10 ` [PULL 0/1] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928155106.GC5904@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).