From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Julia Suvorova" <jusual@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug
Date: Tue, 29 Sep 2020 07:14:34 -0400 [thread overview]
Message-ID: <20200929071412-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAARzgwwFeSPd=JGjdk-uj=uuLb+HcfMfGTe1_GmbFRTkP-jZdQ@mail.gmail.com>
On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote:
> On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote:
> > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote:
> > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote:
> > > > > >
> > > > > > In your pull request the following patch is completely screwed up:
> > > > > >
> > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e
> > > > > > Author: Ani Sinha <ani@anisinha.ca>
> > > > > > Date: Tue Sep 29 03:22:52 2020 -0400
> > > > > >
> > > > > > tests/acpi: update golden master DSDT binary table blobs for q35
> > > > > >
> > > > > >
> > > > > > This is not my patch. It has all sorts of changes which does not
> > > > > > belong there. Can you please check?
> > > > >
> > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/
> > > >
> > > >
> > > > I had to regenerate the binary, yes. That's par for the course.
> > > > But it looks like I added disasssembled files. Will fix up and drop,
> > > > thanks for noticing this.
> >
> > OK I pushed out a fixed variant. Pls take a look.
>
> OK I am not used to this workflow. How am I supposed to get it? Which tag?
New for_upstream tag - I just sent in a pull request.
>
> >
> > > I think DSDT.hbridge is wrong. The checksum looks weird:
> > >
> > >
> > > + * Length 0x00000B89 (2953)
> > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> > > - * Checksum 0x05
> >
> > What is weird about it?
> >
> > >
> > > This file should be introduced just by one patch. my patch.
> >
> > I just re-run rebuild-expected-aml, no changes.
> >
> > I have this:
> > commit 5e3a486211f02d9ecb18939ca21087515ec81883
> > Author: Ani Sinha <ani@anisinha.ca>
> > Date: Fri Sep 18 14:11:05 2020 +0530
> >
> > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag
> >
> > This change adds a new unit test for the global flag
> > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci
> > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support
> > on all pci bridges.
> >
> >
> > Here is the full DSDT header, attached:
> >
> > /*
> > * Intel ACPI Component Architecture
> > * AML/ASL+ Disassembler version 20190509 (64-bit version)
> > * Copyright (c) 2000 - 2019 Intel Corporation
> > *
> > * Disassembling to symbolic ASL+ operators
> > *
> > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020
> > *
> > * Original Table Header:
> > * Signature "DSDT"
> > * Length 0x0000139D (5021)
> > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> > * Checksum 0x05
> > * OEM ID "BOCHS "
> > * OEM Table ID "BXPCDSDT"
> > * OEM Revision 0x00000001 (1)
> > * Compiler ID "BXPC"
> > * Compiler Version 0x00000001 (1)
> > */
> > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
> >
> > --
> > MST
> >
next prev parent reply other threads:[~2020-09-29 11:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 8:40 [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes Ani Sinha
2020-09-18 8:40 ` [PATCH v10 01/13] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug Ani Sinha
2020-09-18 8:41 ` [PATCH v10 02/13] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-09-18 8:41 ` [PATCH v10 03/13] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2020-09-18 8:41 ` [PATCH v10 04/13] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus Ani Sinha
2020-09-18 8:41 ` [PATCH v10 05/13] i440fx/acpi: do not add hotplug related amls for cold plugged bridges Ani Sinha
2020-09-18 8:41 ` [PATCH v10 06/13] tests/acpi: list added acpi table binary file for pci bridge hotplug test Ani Sinha
2020-09-18 8:41 ` [PATCH v10 07/13] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag Ani Sinha
2020-09-18 8:41 ` [PATCH v10 08/13] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Ani Sinha
2020-09-18 8:41 ` [PATCH v10 09/13] Add ACPI DSDT tables for q35 that are being updated by the next patch Ani Sinha
2020-09-18 8:41 ` [PATCH v10 10/13] piix4: don't reserve hw resources when hotplug is off globally Ani Sinha
2020-09-18 8:41 ` [PATCH v10 11/13] tests/acpi: update golden master DSDT binary table blobs for q35 Ani Sinha
2020-09-18 8:41 ` [PATCH v10 12/13] tests/acpi: unit test exercising global pci hotplug off for i440fx Ani Sinha
2020-09-18 8:41 ` [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug Ani Sinha
2020-09-29 7:11 ` Michael S. Tsirkin
2020-09-29 7:23 ` Ani Sinha
2020-09-29 7:26 ` Michael S. Tsirkin
2020-09-29 8:23 ` Ani Sinha
2020-09-29 8:51 ` Ani Sinha
2020-09-29 9:37 ` Ani Sinha
2020-09-29 9:42 ` Michael S. Tsirkin
2020-09-29 9:50 ` Ani Sinha
2020-09-29 10:30 ` Ani Sinha
2020-09-29 10:32 ` Ani Sinha
2020-09-29 10:36 ` Ani Sinha
2020-09-29 10:37 ` Michael S. Tsirkin
2020-09-29 10:41 ` Ani Sinha
2020-09-29 10:50 ` Ani Sinha
2020-09-29 10:57 ` Michael S. Tsirkin
2020-09-29 11:10 ` Ani Sinha
2020-09-29 10:55 ` Michael S. Tsirkin
2020-09-29 11:05 ` Ani Sinha
2020-09-29 11:14 ` Michael S. Tsirkin [this message]
2020-09-29 11:28 ` Ani Sinha
2020-09-29 11:35 ` Michael S. Tsirkin
2020-09-29 12:33 ` Ani Sinha
2020-09-30 7:36 ` Michael S. Tsirkin
2020-09-30 7:39 ` Ani Sinha
2020-09-30 7:43 ` Michael S. Tsirkin
2020-09-30 7:47 ` Ani Sinha
2020-09-30 8:04 ` Michael S. Tsirkin
2020-09-30 8:07 ` Ani Sinha
2020-09-30 9:30 ` Ani Sinha
2020-09-30 15:28 ` Michael S. Tsirkin
2020-09-30 15:45 ` Ani Sinha
2020-09-18 9:55 ` [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes Philippe Mathieu-Daudé
2020-09-18 13:12 ` Ani Sinha
2020-09-18 14:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929071412-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).