From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PULL 2/9] edid: fix physical display size computation
Date: Tue, 29 Sep 2020 11:57:10 +0200 [thread overview]
Message-ID: <20200929095717.26745-3-kraxel@redhat.com> (raw)
In-Reply-To: <20200929095717.26745-1-kraxel@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Divide the resolution by the DPI, and multiply to mm.
Note the computation done for edid[21/22] is correct (in cm).
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20200927145751.365446-2-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/edid-generate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index e58472fde501..618c74e1df39 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -208,8 +208,8 @@ static void edid_desc_timing(uint8_t *desc,
uint32_t dpi)
{
/* physical display size */
- uint32_t xmm = xres * dpi / 254;
- uint32_t ymm = yres * dpi / 254;
+ uint32_t xmm = xres * 254 / 10 / dpi;
+ uint32_t ymm = yres * 254 / 10 / dpi;
/* pull some realistic looking timings out of thin air */
uint32_t xfront = xres * 25 / 100;
--
2.27.0
next prev parent reply other threads:[~2020-09-29 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 9:57 [PULL 0/9] Vga 20200929 patches Gerd Hoffmann
2020-09-29 9:57 ` [PULL 1/9] virtio-gpu-3d: fix abnormal display after a warm reboot Gerd Hoffmann
2020-09-29 9:57 ` Gerd Hoffmann [this message]
2020-09-29 9:57 ` [PULL 3/9] edid: use physical dimensions if available Gerd Hoffmann
2020-09-29 9:57 ` [PULL 4/9] ui: add getter for UIInfo Gerd Hoffmann
2020-09-29 9:57 ` [PULL 5/9] spice: remove the single monitor config logic Gerd Hoffmann
2020-09-29 9:57 ` [PULL 6/9] spice: get monitors physical dimension Gerd Hoffmann
2020-09-29 9:57 ` [PULL 7/9] virtio-gpu: set physical dimensions for EDID Gerd Hoffmann
2020-09-29 9:57 ` [PULL 8/9] virtio-vga: implement big-endian-framebuffer property Gerd Hoffmann
2020-09-29 9:57 ` [PULL 9/9] ppc/pseries: enable big-endian-framebuffer quirk for bochs-display and virtio-vga Gerd Hoffmann
2020-09-29 12:18 ` [PULL 0/9] Vga 20200929 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929095717.26745-3-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).