From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
mreitz@redhat.com
Subject: [PATCH 3/4] qom: Add user_creatable_print_help_from_qdict()
Date: Tue, 29 Sep 2020 19:26:48 +0200 [thread overview]
Message-ID: <20200929172649.158086-4-kwolf@redhat.com> (raw)
In-Reply-To: <20200929172649.158086-1-kwolf@redhat.com>
This adds a function that, given a QDict of non-help options, prints
help for user creatable objects.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
include/qom/object_interfaces.h | 9 +++++++++
qom/object_interfaces.c | 9 +++++++++
2 files changed, 18 insertions(+)
diff --git a/include/qom/object_interfaces.h b/include/qom/object_interfaces.h
index f118fb516b..53b114b11a 100644
--- a/include/qom/object_interfaces.h
+++ b/include/qom/object_interfaces.h
@@ -161,6 +161,15 @@ int user_creatable_add_opts_foreach(void *opaque,
*/
bool user_creatable_print_help(const char *type, QemuOpts *opts);
+/**
+ * user_creatable_print_help_from_qdict:
+ * @args: options to create
+ *
+ * Prints help considering the other options given in @args (if "qom-type" is
+ * given and valid, print properties for the type, otherwise print valid types)
+ */
+void user_creatable_print_help_from_qdict(QDict *args);
+
/**
* user_creatable_del:
* @id: the unique ID for the object
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index 3fd1da157e..ed896fe764 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -279,6 +279,15 @@ bool user_creatable_print_help(const char *type, QemuOpts *opts)
return false;
}
+void user_creatable_print_help_from_qdict(QDict *args)
+{
+ const char *type = qdict_get_try_str(args, "qom-type");
+
+ if (!type || !user_creatable_print_type_properites(type)) {
+ user_creatable_print_types();
+ }
+}
+
bool user_creatable_del(const char *id, Error **errp)
{
Object *container;
--
2.25.4
next prev parent reply other threads:[~2020-09-29 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 17:26 [PATCH 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser Kevin Wolf
2020-09-29 17:26 ` [PATCH 1/4] keyval: Parse help options Kevin Wolf
2020-09-29 17:46 ` Eric Blake
2020-09-30 13:04 ` Kevin Wolf
2020-09-30 13:42 ` Eric Blake
2020-09-30 14:56 ` Kevin Wolf
2020-10-09 14:36 ` Markus Armbruster
2020-09-29 17:26 ` [PATCH 2/4] qom: Factor out helpers from user_creatable_print_help() Kevin Wolf
2020-09-29 17:51 ` Eric Blake
2020-09-29 17:26 ` Kevin Wolf [this message]
2020-09-29 17:53 ` [PATCH 3/4] qom: Add user_creatable_print_help_from_qdict() Eric Blake
2020-09-29 17:26 ` [PATCH 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser Kevin Wolf
2020-09-29 17:54 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929172649.158086-4-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).