From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH RFC v2 18/19] i386: use global kvm_state in hyperv_enabled() check
Date: Wed, 30 Sep 2020 15:40:26 +0200 [thread overview]
Message-ID: <20200930134027.1348021-19-vkuznets@redhat.com> (raw)
In-Reply-To: <20200930134027.1348021-1-vkuznets@redhat.com>
There is no need to use vCPU-specific kvm state in hyperv_enabled() check
and we need to do that when feature expansion happens early, before vCPU
specific KVM state is created.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
target/i386/kvm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index af59b5f1a935..2c62122a1bc8 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -729,8 +729,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cs)
static bool hyperv_enabled(X86CPU *cpu)
{
- CPUState *cs = CPU(cpu);
- return kvm_check_extension(cs->kvm_state, KVM_CAP_HYPERV) > 0 &&
+ return kvm_check_extension(kvm_state, KVM_CAP_HYPERV) > 0 &&
((cpu->hyperv_spinlock_attempts != HYPERV_SPINLOCK_NEVER_NOTIFY) ||
cpu->hyperv_features || cpu->hyperv_passthrough);
}
--
2.25.4
next prev parent reply other threads:[~2020-09-30 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:40 [PATCH RFC v2 00/19] i386: KVM: expand Hyper-V features early Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 01/19] WIP: update linux/headers Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 02/19] i386: fill in FEAT_HYPERV_EDX from edx instead of eax Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 03/19] i386: drop x86_cpu_get_supported_feature_word() forward declaration Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 04/19] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn() Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 05/19] i386: move hyperv_interface_id " Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 06/19] i386: move hyperv_version_id " Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 07/19] i386: move hyperv_limits " Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 08/19] i386: keep hyperv_vendor string up-to-date Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 09/19] i386: invert hyperv_spinlock_attempts setting logic with hv_passthrough Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 10/19] i386: always fill Hyper-V CPUID feature leaves from X86CPU data Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 11/19] i386: introduce hv_cpuid_cache Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 12/19] i386: drop FEAT_HYPERV feature leaves Vitaly Kuznetsov
2020-09-30 14:36 ` Eduardo Habkost
2020-09-30 14:56 ` Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 13/19] i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids() Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 14/19] i386: move eVMCS enablement to hyperv_init_vcpu() Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 15/19] i386: switch hyperv_expand_features() to using error_setg() Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 16/19] i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array size Vitaly Kuznetsov
2020-09-30 13:40 ` [PATCH RFC v2 17/19] i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one Vitaly Kuznetsov
2020-09-30 13:40 ` Vitaly Kuznetsov [this message]
2020-09-30 13:40 ` [PATCH RFC v2 19/19] i386: expand Hyper-V features during CPU feature expansion time Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930134027.1348021-19-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).