qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
	qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Peter Lieven" <pl@kamp.de>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v3 11/11] qapi: Restrict code generated for user-mode
Date: Wed, 30 Sep 2020 18:49:49 +0200	[thread overview]
Message-ID: <20200930164949.1425294-12-philmd@redhat.com> (raw)
In-Reply-To: <20200930164949.1425294-1-philmd@redhat.com>

A lot of QAPI generated code is never used by user-mode.

Split out qapi_system_modules and qapi_system_or_tools_modules
from the qapi_all_modules array. We now have 3 groups:
- always used
- use by system-mode or tools (usually by the block layer)
- only used by system-mode

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Resetting due to Meson update:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 qapi/meson.build | 51 ++++++++++++++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 15 deletions(-)

diff --git a/qapi/meson.build b/qapi/meson.build
index 7c4a89a882..ba9677ba97 100644
--- a/qapi/meson.build
+++ b/qapi/meson.build
@@ -14,39 +14,60 @@ util_ss.add(files(
 ))
 
 qapi_all_modules = [
+  'common',
+  'introspect',
+  'misc',
+]
+
+qapi_system_modules = [
   'acpi',
   'audio',
+  'dump',
+  'machine-target',
+  'machine',
+  'migration',
+  'misc-target',
+  'net',
+  'pci',
+  'qdev',
+  'rdma',
+  'rocker',
+  'tpm',
+  'trace',
+]
+
+# system or tools
+qapi_block_modules = [
   'authz',
   'block-core',
   'block',
   'char',
-  'common',
   'control',
   'crypto',
-  'dump',
   'error',
-  'introspect',
   'job',
-  'machine',
-  'machine-target',
-  'migration',
-  'misc',
-  'misc-target',
-  'net',
   'pragma',
-  'qdev',
-  'pci',
   'qom',
-  'rdma',
-  'rocker',
   'run-state',
   'sockets',
-  'tpm',
-  'trace',
   'transaction',
   'ui',
 ]
 
+if have_system
+  qapi_all_modules += qapi_system_modules
+elif have_user
+  # Temporary kludge because X86CPUFeatureWordInfo is not
+  # restricted to system-mode. This should be removed (along
+  # with target/i386/feature-stub.c) once target/i386/cpu.c
+  # has been cleaned.
+  qapi_all_modules += ['machine-target']
+endif
+
+if have_block
+  qapi_all_modules += qapi_block_modules
+endif
+
 qapi_storage_daemon_modules = [
   'block-core',
   'char',
-- 
2.26.2



  parent reply	other threads:[~2020-09-30 16:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 16:49 [PATCH v3 00/11] user-mode: Prune build dependencies (part 3) Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 01/11] qapi: Restrict query-uuid command to block code Philippe Mathieu-Daudé
2020-10-01  5:04   ` Markus Armbruster
2020-10-01 10:22     ` Philippe Mathieu-Daudé
2020-10-01 12:24       ` Markus Armbruster
2020-09-30 16:49 ` [PATCH v3 02/11] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 03/11] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr() Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 04/11] hw/core/qdev-properties: Fix code style Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 05/11] hw/core/qdev-properties: Export enum-related functions Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 06/11] hw/core/qdev-properties: Export qdev_prop_enum Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 07/11] hw/core/qdev-properties: Export some integer-related functions Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 08/11] hw/core/qdev-properties: Extract system-mode specific properties Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 09/11] hw/core: Add qdev stub for user-mode Philippe Mathieu-Daudé
2020-09-30 16:49 ` [PATCH v3 10/11] target/i386: Restrict X86CPUFeatureWord to X86 targets Philippe Mathieu-Daudé
2020-09-30 17:18   ` Eduardo Habkost
2020-09-30 16:49 ` Philippe Mathieu-Daudé [this message]
2020-10-01  5:09   ` [PATCH v3 11/11] qapi: Restrict code generated for user-mode Markus Armbruster
2020-10-01 10:23     ` Philippe Mathieu-Daudé
2020-09-30 17:15 ` [PATCH v3 00/11] user-mode: Prune build dependencies (part 3) Eduardo Habkost
2020-09-30 17:24   ` Paolo Bonzini
2020-09-30 17:27     ` Eduardo Habkost
2020-10-01 12:56       ` Philippe Mathieu-Daudé
2020-09-30 18:56     ` Alex Bennée
2020-09-30 19:05       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930164949.1425294-12-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).