qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: [PULL 31/86] meson: extend libmpathpersist test for static linking
Date: Wed, 30 Sep 2020 21:58:50 +0200	[thread overview]
Message-ID: <20200930195850.278104-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20200930195850.278104-1-pbonzini@redhat.com>

libmultipath has a dependency on libdevmapper, so
include it as well when static linking.  It seems that
the rabbit hole ends there.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/meson.build b/meson.build
index 8e9cd67235..5dd7728cc9 100644
--- a/meson.build
+++ b/meson.build
@@ -302,14 +302,25 @@ if targetos == 'linux' and have_tools and not get_option('mpath').disabled()
           mpath_lib_init(udev);
           return 0;
       }'''
-  libmultipath = cc.find_library('multipath',
-                                 required: get_option('mpath'),
-                                 static: enable_static)
-  libmpathpersist = cc.find_library('mpathpersist',
-                                    required: get_option('mpath'),
-                                    static: enable_static)
-  if libmultipath.found() and libmpathpersist.found() and libudev.found()
-    mpathlibs = [libmultipath, libmpathpersist, libudev]
+  mpathlibs = [libudev]
+  if enable_static
+    mpathlibs += cc.find_library('devmapper',
+                                   required: get_option('mpath'),
+                                   static: enable_static)
+  endif
+  mpathlibs += cc.find_library('multipath',
+                               required: get_option('mpath'),
+                               static: enable_static)
+  mpathlibs += cc.find_library('mpathpersist',
+                               required: get_option('mpath'),
+                               static: enable_static)
+  foreach lib: mpathlibs
+    if not lib.found()
+      mpathlibs = []
+      break
+    endif
+  endforeach
+  if mpathlibs.length() > 0
     if cc.links(mpath_test_source_new, dependencies: mpathlibs)
       mpathpersist = declare_dependency(dependencies: mpathlibs)
       mpathpersist_new_api = true
-- 
2.26.2


  parent reply	other threads:[~2020-09-30 20:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 19:58 [PULL v8 00/86] Misc QEMU patches for 2020-09-24 Paolo Bonzini
2020-09-30 19:58 ` [PULL 29/86] meson: move libudev test Paolo Bonzini
2020-10-01 16:19   ` Peter Maydell
2020-10-01 16:55     ` Paolo Bonzini
2020-10-01 18:51       ` Peter Maydell
2020-10-01 19:15         ` Paolo Bonzini
2020-09-30 19:58 ` [PULL 30/86] meson: move libmpathpersist test Paolo Bonzini
2020-09-30 19:58 ` Paolo Bonzini [this message]
2020-10-01 14:28 ` [PULL v8 00/86] Misc QEMU patches for 2020-09-24 Peter Maydell
2020-10-01 15:41   ` 罗勇刚(Yonggang Luo)
2020-10-02 15:58 ` Michal Prívozník
2020-10-02 16:22   ` Eduardo Habkost
2020-10-02 17:26     ` Michal Prívozník
2020-10-02 17:30       ` Paolo Bonzini
2020-10-02 17:55         ` Eduardo Habkost
2020-10-02 16:27   ` Paolo Bonzini
2020-10-02 17:01     ` Eduardo Habkost
2020-10-02 18:24     ` Eduardo Habkost
2020-10-02 18:45       ` Paolo Bonzini
2020-10-02 18:52         ` Peter Maydell
2020-10-07 10:57       ` Michal Privoznik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930195850.278104-4-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).