From: Jens Freimann <jfreimann@redhat.com>
To: dgilbert@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org
Cc: fidencio@redhat.com
Subject: [RFC 1/1] tools/virtiofsd: create temporary directory in /tmp
Date: Thu, 1 Oct 2020 08:15:19 +0200 [thread overview]
Message-ID: <20201001061519.636959-2-jfreimann@redhat.com> (raw)
In-Reply-To: <20201001061519.636959-1-jfreimann@redhat.com>
mkdtemp() will try to create a current directory in the working
directory of the process. In this case it's trying to create it in /.
This is a problem when the process doesn't have write access there.
This patch changes the template string and prepends "/tmp" which is
typically writable.
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 0b229ebd57..f79bcce0d7 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -2393,7 +2393,7 @@ static void setup_wait_parent_capabilities(void)
static void setup_namespaces(struct lo_data *lo, struct fuse_session *se)
{
pid_t child;
- char template[] = "virtiofsd-XXXXXX";
+ char template[] = "/tmp/virtiofsd-XXXXXX";
char *tmpdir;
/*
--
2.26.2
next prev parent reply other threads:[~2020-10-01 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 6:15 [RFC 0/1] tools/virtiofsd: don't create temporary directory in / Jens Freimann
2020-10-01 6:15 ` Jens Freimann [this message]
2020-10-06 10:00 ` [RFC 1/1] tools/virtiofsd: create temporary directory in /tmp Stefan Hajnoczi
2020-10-05 13:58 ` [RFC 0/1] tools/virtiofsd: don't create temporary directory in / Jens Freimann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001061519.636959-2-jfreimann@redhat.com \
--to=jfreimann@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fidencio@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).