* [PATCH] hw/block/nvme: Simplify timestamp sum
@ 2020-10-02 7:57 Philippe Mathieu-Daudé
2020-10-02 8:01 ` Klaus Jensen
2020-10-12 12:24 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-02 7:57 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, qemu-trivial, Max Reitz, Klaus Jensen,
Keith Busch, Philippe Mathieu-Daudé
As the 'timestamp' variable is declared as a 48-bit bitfield,
we do not need to wrap the sum result.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/block/nvme.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 63078f6009..44fa5b9076 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1280,12 +1280,7 @@ static inline uint64_t nvme_get_timestamp(const NvmeCtrl *n)
union nvme_timestamp ts;
ts.all = 0;
-
- /*
- * If the sum of the Timestamp value set by the host and the elapsed
- * time exceeds 2^48, the value returned should be reduced modulo 2^48.
- */
- ts.timestamp = (n->host_timestamp + elapsed_time) & 0xffffffffffff;
+ ts.timestamp = n->host_timestamp + elapsed_time;
/* If the host timestamp is non-zero, set the timestamp origin */
ts.origin = n->host_timestamp ? 0x01 : 0x00;
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/block/nvme: Simplify timestamp sum
2020-10-02 7:57 [PATCH] hw/block/nvme: Simplify timestamp sum Philippe Mathieu-Daudé
@ 2020-10-02 8:01 ` Klaus Jensen
2020-10-12 12:24 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Klaus Jensen @ 2020-10-02 8:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Kevin Wolf, qemu-block, qemu-trivial, qemu-devel, Max Reitz,
Keith Busch
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
On Oct 2 09:57, Philippe Mathieu-Daudé wrote:
> As the 'timestamp' variable is declared as a 48-bit bitfield,
> we do not need to wrap the sum result.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/nvme.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 63078f6009..44fa5b9076 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1280,12 +1280,7 @@ static inline uint64_t nvme_get_timestamp(const NvmeCtrl *n)
>
> union nvme_timestamp ts;
> ts.all = 0;
> -
> - /*
> - * If the sum of the Timestamp value set by the host and the elapsed
> - * time exceeds 2^48, the value returned should be reduced modulo 2^48.
> - */
> - ts.timestamp = (n->host_timestamp + elapsed_time) & 0xffffffffffff;
> + ts.timestamp = n->host_timestamp + elapsed_time;
>
> /* If the host timestamp is non-zero, set the timestamp origin */
> ts.origin = n->host_timestamp ? 0x01 : 0x00;
> --
> 2.26.2
>
>
--
One of us - No more doubt, silence or taboo about mental illness.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/block/nvme: Simplify timestamp sum
2020-10-02 7:57 [PATCH] hw/block/nvme: Simplify timestamp sum Philippe Mathieu-Daudé
2020-10-02 8:01 ` Klaus Jensen
@ 2020-10-12 12:24 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-10-12 12:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Kevin Wolf, qemu-block, qemu-trivial, Max Reitz, Klaus Jensen,
Keith Busch
Le 02/10/2020 à 09:57, Philippe Mathieu-Daudé a écrit :
> As the 'timestamp' variable is declared as a 48-bit bitfield,
> we do not need to wrap the sum result.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/block/nvme.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 63078f6009..44fa5b9076 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1280,12 +1280,7 @@ static inline uint64_t nvme_get_timestamp(const NvmeCtrl *n)
>
> union nvme_timestamp ts;
> ts.all = 0;
> -
> - /*
> - * If the sum of the Timestamp value set by the host and the elapsed
> - * time exceeds 2^48, the value returned should be reduced modulo 2^48.
> - */
> - ts.timestamp = (n->host_timestamp + elapsed_time) & 0xffffffffffff;
> + ts.timestamp = n->host_timestamp + elapsed_time;
>
> /* If the host timestamp is non-zero, set the timestamp origin */
> ts.origin = n->host_timestamp ? 0x01 : 0x00;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-12 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-02 7:57 [PATCH] hw/block/nvme: Simplify timestamp sum Philippe Mathieu-Daudé
2020-10-02 8:01 ` Klaus Jensen
2020-10-12 12:24 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).