From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] ppc/pnv: Increase max firware size
Date: Fri, 2 Oct 2020 09:26:10 +0200 [thread overview]
Message-ID: <20201002092610.36b38900@bahia.lan> (raw)
In-Reply-To: <81451df1-43d5-43ce-e3cf-703d78333841@kaod.org>
On Fri, 2 Oct 2020 08:15:46 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> That was sent a bit fast. Can you please add in the commit log :
>
> Builds enabling GCOV can be bigger than 4MB and the limit on FSP
> systems is 16MB.
>
> Thanks
>
And also s/firware/firmware in the title.
Cheers,
--
Greg
> C.
>
> On 10/2/20 8:13 AM, Cédric Le Goater wrote:
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > ---
> > hw/ppc/pnv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> > index 6670967e26a9..d9e52873ea70 100644
> > --- a/hw/ppc/pnv.c
> > +++ b/hw/ppc/pnv.c
> > @@ -61,7 +61,7 @@
> >
> > #define FW_FILE_NAME "skiboot.lid"
> > #define FW_LOAD_ADDR 0x0
> > -#define FW_MAX_SIZE (4 * MiB)
> > +#define FW_MAX_SIZE (16 * MiB)
> >
> > #define KERNEL_LOAD_ADDR 0x20000000
> > #define KERNEL_MAX_SIZE (256 * MiB)
> >
>
>
next prev parent reply other threads:[~2020-10-02 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 6:13 [PATCH] ppc/pnv: Increase max firware size Cédric Le Goater
2020-10-02 6:15 ` Cédric Le Goater
2020-10-02 7:26 ` Greg Kurz [this message]
2020-10-02 9:15 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002092610.36b38900@bahia.lan \
--to=groug@kaod.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).