* [PATCH] ppc/pnv: Increase max firware size
@ 2020-10-02 6:13 Cédric Le Goater
2020-10-02 6:15 ` Cédric Le Goater
0 siblings, 1 reply; 4+ messages in thread
From: Cédric Le Goater @ 2020-10-02 6:13 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel, Cédric Le Goater
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/ppc/pnv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 6670967e26a9..d9e52873ea70 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -61,7 +61,7 @@
#define FW_FILE_NAME "skiboot.lid"
#define FW_LOAD_ADDR 0x0
-#define FW_MAX_SIZE (4 * MiB)
+#define FW_MAX_SIZE (16 * MiB)
#define KERNEL_LOAD_ADDR 0x20000000
#define KERNEL_MAX_SIZE (256 * MiB)
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pnv: Increase max firware size
2020-10-02 6:13 [PATCH] ppc/pnv: Increase max firware size Cédric Le Goater
@ 2020-10-02 6:15 ` Cédric Le Goater
2020-10-02 7:26 ` Greg Kurz
0 siblings, 1 reply; 4+ messages in thread
From: Cédric Le Goater @ 2020-10-02 6:15 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel
That was sent a bit fast. Can you please add in the commit log :
Builds enabling GCOV can be bigger than 4MB and the limit on FSP
systems is 16MB.
Thanks
C.
On 10/2/20 8:13 AM, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/pnv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 6670967e26a9..d9e52873ea70 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -61,7 +61,7 @@
>
> #define FW_FILE_NAME "skiboot.lid"
> #define FW_LOAD_ADDR 0x0
> -#define FW_MAX_SIZE (4 * MiB)
> +#define FW_MAX_SIZE (16 * MiB)
>
> #define KERNEL_LOAD_ADDR 0x20000000
> #define KERNEL_MAX_SIZE (256 * MiB)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pnv: Increase max firware size
2020-10-02 6:15 ` Cédric Le Goater
@ 2020-10-02 7:26 ` Greg Kurz
2020-10-02 9:15 ` Cédric Le Goater
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kurz @ 2020-10-02 7:26 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-ppc, qemu-devel, David Gibson
On Fri, 2 Oct 2020 08:15:46 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> That was sent a bit fast. Can you please add in the commit log :
>
> Builds enabling GCOV can be bigger than 4MB and the limit on FSP
> systems is 16MB.
>
> Thanks
>
And also s/firware/firmware in the title.
Cheers,
--
Greg
> C.
>
> On 10/2/20 8:13 AM, Cédric Le Goater wrote:
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > ---
> > hw/ppc/pnv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> > index 6670967e26a9..d9e52873ea70 100644
> > --- a/hw/ppc/pnv.c
> > +++ b/hw/ppc/pnv.c
> > @@ -61,7 +61,7 @@
> >
> > #define FW_FILE_NAME "skiboot.lid"
> > #define FW_LOAD_ADDR 0x0
> > -#define FW_MAX_SIZE (4 * MiB)
> > +#define FW_MAX_SIZE (16 * MiB)
> >
> > #define KERNEL_LOAD_ADDR 0x20000000
> > #define KERNEL_MAX_SIZE (256 * MiB)
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ppc/pnv: Increase max firware size
2020-10-02 7:26 ` Greg Kurz
@ 2020-10-02 9:15 ` Cédric Le Goater
0 siblings, 0 replies; 4+ messages in thread
From: Cédric Le Goater @ 2020-10-02 9:15 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-ppc, qemu-devel, David Gibson
On 10/2/20 9:26 AM, Greg Kurz wrote:
> On Fri, 2 Oct 2020 08:15:46 +0200
> Cédric Le Goater <clg@kaod.org> wrote:
>
>> That was sent a bit fast. Can you please add in the commit log :
>>
>> Builds enabling GCOV can be bigger than 4MB and the limit on FSP
>> systems is 16MB.
>>
>> Thanks
>>
>
> And also s/firware/firmware in the title.
bah. sending a v2.
Thanks,
C.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-02 9:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-02 6:13 [PATCH] ppc/pnv: Increase max firware size Cédric Le Goater
2020-10-02 6:15 ` Cédric Le Goater
2020-10-02 7:26 ` Greg Kurz
2020-10-02 9:15 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).