From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH] meson.build: Don't look for libudev for static builds
Date: Fri, 2 Oct 2020 11:52:39 +0100 [thread overview]
Message-ID: <20201002105239.2444-1-peter.maydell@linaro.org> (raw)
commit f01496a314d916 moved the logic for detecting libudev from
configure to meson.build, but in the process it dropped the condition
that meant we only ask pkg-config about libudev for a non-static
build.
This breaks static builds of the system emulators on at least Ubuntu
18.04.4, because on that host there is no static libudev but
pkg-config still claims it exists.
Reinstate the logic that we had in the configure check.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
We could certainly do something cleverer here, but basic "convert
from configure to meson" should in general not also be changing the
detection logic IMHO. We can make the logic smarter as a follow-on
patch if desired.
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 3161c1f037a..07da66e1d81 100644
--- a/meson.build
+++ b/meson.build
@@ -271,7 +271,7 @@ if 'CONFIG_CURL' in config_host
link_args: config_host['CURL_LIBS'].split())
endif
libudev = not_found
-if targetos == 'linux' and (have_system or have_tools)
+if targetos == 'linux' and (have_system or have_tools) and not enable_static
libudev = dependency('libudev',
required: get_option('mpath').enabled(),
static: enable_static)
--
2.20.1
next reply other threads:[~2020-10-02 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 10:52 Peter Maydell [this message]
2020-10-02 11:15 ` [PATCH] meson.build: Don't look for libudev for static builds 罗勇刚(Yonggang Luo)
2020-10-02 12:03 ` Paolo Bonzini
2020-10-02 12:02 ` Paolo Bonzini
2020-10-02 12:35 ` Peter Maydell
2020-10-02 12:36 ` Peter Maydell
2020-10-02 12:43 ` Paolo Bonzini
2020-10-02 13:01 ` Peter Maydell
2020-10-02 13:05 ` Paolo Bonzini
2020-10-02 13:09 ` Peter Maydell
2020-10-02 14:08 ` Paolo Bonzini
2020-10-02 14:18 ` Peter Maydell
2020-10-02 15:14 ` Paolo Bonzini
2020-10-02 15:28 ` Peter Maydell
2020-10-03 7:24 ` 罗勇刚(Yonggang Luo)
2020-10-03 7:50 ` Paolo Bonzini
2020-10-03 8:28 ` 罗勇刚(Yonggang Luo)
2020-10-03 8:42 ` Paolo Bonzini
2020-10-03 8:29 ` 罗勇刚(Yonggang Luo)
2020-10-03 8:43 ` Paolo Bonzini
2020-10-03 9:32 ` 罗勇刚(Yonggang Luo)
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] meson.build: Don't look for libudev for static builds Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002105239.2444-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).