From: Brian Turek <brian.turek@gmail.com>
To: qemu-devel@nongnu.org
Cc: Brian Turek <brian.turek@gmail.com>
Subject: [PATCH 1/1] docs: Clarify formatting for 'fmode' and 'dmode'
Date: Tue, 6 Oct 2020 21:25:01 +0100 [thread overview]
Message-ID: <20201006202501.81537-2-brian.turek@gmail.com> (raw)
In-Reply-To: <20201006202501.81537-1-brian.turek@gmail.com>
Explictly state that the 'fmode' and 'dmode' values for a fsdev/virtfs
must be formatted with a preceeding 0 to be interpreted as base-8.
Currently the code will parse a value like "644" as base-10 which leads
to unexpected behavior.
Signed-off-by: Brian Turek <brian.turek@gmail.com>
---
qemu-options.hx | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 1da52a269c..b92f32005a 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1492,12 +1492,16 @@ SRST
``fmode=fmode``
Specifies the default mode for newly created files on the host.
Works only with security models "mapped-xattr" and
- "mapped-file".
+ "mapped-file". Must be formatted with a preceeding 0 to be
+ interpreted as a octal value (e.g. 0644). The setuid, setgid,
+ and sticky bit are all ignored.
``dmode=dmode``
Specifies the default mode for newly created directories on the
host. Works only with security models "mapped-xattr" and
- "mapped-file".
+ "mapped-file". Must be formatted with a preceeding 0 to be
+ interpreted as a octal value (e.g. 0755). The setuid, setgid,
+ and sticky bit are all ignored.
``throttling.bps-total=b,throttling.bps-read=r,throttling.bps-write=w``
Specify bandwidth throttling limits in bytes per second, either
--
2.25.1
prev parent reply other threads:[~2020-10-06 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 20:25 [PATCH 0/1] docs: Clarify formatting for 'fmode' and 'dmode' Brian Turek
2020-10-06 20:25 ` Brian Turek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006202501.81537-2-brian.turek@gmail.com \
--to=brian.turek@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).