qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Li Qiang" <liq3ea@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 09/21] qom: Improve error message displayed with missing object properties
Date: Tue,  6 Oct 2020 18:09:18 -0400	[thread overview]
Message-ID: <20201006220930.908275-10-ehabkost@redhat.com> (raw)
In-Reply-To: <20201006220930.908275-1-ehabkost@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Instead of only displaying the property missing, also display
the object name. This help developer to quickly figure out the
mistake without opening a debugger.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200920155340.401482-1-f4bug@amsat.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 qom/object.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qom/object.c b/qom/object.c
index c335dce7e4..1065355233 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1291,7 +1291,8 @@ ObjectProperty *object_property_find_err(Object *obj, const char *name,
 {
     ObjectProperty *prop = object_property_find(obj, name);
     if (!prop) {
-        error_setg(errp, "Property '.%s' not found", name);
+        error_setg(errp, "Property '%s.%s' not found",
+                   object_get_typename(obj), name);
     }
     return prop;
 }
-- 
2.26.2



  parent reply	other threads:[~2020-10-06 22:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 22:09 [PULL 00/21] machine + QOM queue, 2020-10-06 Eduardo Habkost
2020-10-06 22:09 ` [PULL 01/21] hw/core/qdev-properties: Use qemu_strtol() in set_mac() handler Eduardo Habkost
2020-10-06 22:09 ` [PULL 02/21] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr() Eduardo Habkost
2020-10-06 22:09 ` [PULL 03/21] hw/core/qdev-properties: Fix code style Eduardo Habkost
2020-10-06 22:09 ` [PULL 04/21] hw/core/qdev-properties: Export enum-related functions Eduardo Habkost
2020-10-06 22:09 ` [PULL 05/21] hw/core/qdev-properties: Export qdev_prop_enum Eduardo Habkost
2020-10-06 22:09 ` [PULL 06/21] hw/core/qdev-properties: Export some integer-related functions Eduardo Habkost
2020-10-06 22:09 ` [PULL 07/21] hw/core/qdev-properties: Extract system-mode specific properties Eduardo Habkost
2020-10-06 22:09 ` [PULL 08/21] hw/core/cpu: Add missing 'exec/cpu-common.h' include Eduardo Habkost
2020-10-06 22:09 ` Eduardo Habkost [this message]
2020-10-06 22:09 ` [PULL 10/21] qom: Fix DECLARE_*CHECKER documentation Eduardo Habkost
2020-10-06 22:09 ` [PULL 11/21] docs/devel/qom: Fix indentation of bulleted list Eduardo Habkost
2020-10-06 22:09 ` [PULL 12/21] docs/devel/qom: Fix indentation of code blocks Eduardo Habkost
2020-10-06 22:09 ` [PULL 13/21] docs/devel/qom: Use *emphasis* for emphasis Eduardo Habkost
2020-10-06 22:09 ` [PULL 14/21] docs/devel/qom: Remove usage of <code> Eduardo Habkost
2020-10-06 22:09 ` [PULL 15/21] docs/devel/qom: Avoid long lines Eduardo Habkost
2020-10-06 22:09 ` [PULL 16/21] kernel-doc: Handle function typedefs that return pointers Eduardo Habkost
2020-10-06 22:09 ` [PULL 17/21] kernel-doc: Handle function typedefs without asterisks Eduardo Habkost
2020-10-06 22:09 ` [PULL 18/21] qom: Explicitly tag doc comments for typedefs and structs Eduardo Habkost
2020-10-06 22:09 ` [PULL 19/21] memory: Explicitly tag doc comments for structs Eduardo Habkost
2020-10-06 22:09 ` [PULL 20/21] kernel-doc: Remove $decl_type='type name' hack Eduardo Habkost
2020-10-06 22:09 ` [PULL 21/21] numa: hmat: require parent cache description before the next level one Eduardo Habkost
2020-10-08 14:26 ` [PULL 00/21] machine + QOM queue, 2020-10-06 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006220930.908275-10-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=liq3ea@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).