From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, vgoyal@redhat.com, stefanha@redhat.com,
virtio-fs@redhat.com
Subject: Re: [PATCH v2 1/6] virtiofsd: Silence gcc warning
Date: Wed, 7 Oct 2020 11:42:11 +0100 [thread overview]
Message-ID: <20201007104211.GA22258@work-vm> (raw)
In-Reply-To: <20200827153657.111098-2-dgilbert@redhat.com>
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Gcc worries fd might be used unset, in reality it's always set if
> fi is set, and only used if fi is set so it's safe. Initialise it to -1
> just to keep gcc happy for now.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued (just this patch)
> ---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 63d1d00565..083d17a960 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -617,7 +617,7 @@ static void lo_setattr(fuse_req_t req, fuse_ino_t ino, struct stat *attr,
> struct lo_inode *inode;
> int ifd;
> int res;
> - int fd;
> + int fd = -1;
>
> inode = lo_inode(req, ino);
> if (!inode) {
> --
> 2.26.2
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-10-07 10:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:36 [PATCH v2 0/6] virtiofsd xattr name mappings Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [PATCH v2 1/6] virtiofsd: Silence gcc warning Dr. David Alan Gilbert (git)
2020-09-09 11:16 ` Ján Tomko
2020-10-07 10:42 ` Dr. David Alan Gilbert [this message]
2020-08-27 15:36 ` [PATCH v2 2/6] virtiofsd: Add printf checking to fuse_log Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [PATCH v2 3/6] tools/virtiofsd: xattr name mappings: Add option Dr. David Alan Gilbert (git)
2020-09-09 11:20 ` Ján Tomko
2020-09-10 18:38 ` Dr. David Alan Gilbert
2020-09-11 21:13 ` [Virtio-fs] " Vivek Goyal
2020-09-18 17:38 ` Dr. David Alan Gilbert
2020-10-20 17:20 ` Vivek Goyal
2020-10-06 15:51 ` Christophe de Dinechin
2020-10-14 15:40 ` Dr. David Alan Gilbert
2020-08-27 15:36 ` [PATCH v2 4/6] tools/virtiofsd: xattr name mappings: Map client xattr names Dr. David Alan Gilbert (git)
2020-08-27 15:36 ` [PATCH v2 5/6] tools/virtiofsd: xattr name mappings: Map server " Dr. David Alan Gilbert (git)
2020-10-06 16:03 ` Christophe de Dinechin
2020-10-14 16:04 ` Dr. David Alan Gilbert
2020-10-06 16:17 ` Christophe de Dinechin
2020-08-27 15:36 ` [PATCH v2 6/6] tools/virtiofsd: xattr name mapping examples Dr. David Alan Gilbert (git)
2020-09-09 11:35 ` Ján Tomko
2020-09-10 18:42 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007104211.GA22258@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).