From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9268BC4363C for ; Wed, 7 Oct 2020 10:59:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BDCE212CC for ; Wed, 7 Oct 2020 10:59:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EZ/nvzGK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BDCE212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ7AN-0007aS-Uo for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 06:59:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ77T-0004yN-9T for qemu-devel@nongnu.org; Wed, 07 Oct 2020 06:56:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQ77Q-0002J7-Cg for qemu-devel@nongnu.org; Wed, 07 Oct 2020 06:56:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602068182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNvglqXwJBAXVeHbKWiEjG9B+DEfbS4sG1pV1D6iPzw=; b=EZ/nvzGKmCWX/u8e0ylKohnmZvGvXxItXeQl1CjdvEizQKHAkkuUnky5YgTE3Pf5ONSGq0 6lFkXQitJmy2tOiquyjqe6JnOcfLghldPKqFhWkN8kEYBIGmrz8J1SFx0jo3TjPl4/83bl b4xIULMRWvtrxwrq+O8nvTrFAYwGrRY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-eOwEPCcJN_eG5dW2YuXXHQ-1; Wed, 07 Oct 2020 06:56:21 -0400 X-MC-Unique: eOwEPCcJN_eG5dW2YuXXHQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1E71618A8231; Wed, 7 Oct 2020 10:56:20 +0000 (UTC) Received: from work-vm (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB79360BF1; Wed, 7 Oct 2020 10:56:15 +0000 (UTC) Date: Wed, 7 Oct 2020 11:56:13 +0100 From: "Dr. David Alan Gilbert" To: qemu-devel@nongnu.org, alex.bennee@linaro.org, stefanha@redhat.com Subject: Re: [PATCH] virtiofsd: Call qemu_init_exec_dir Message-ID: <20201007105613.GB22258@work-vm> References: <20201002124015.44820-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201002124015.44820-1-dgilbert@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:44:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.733, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Since fcb4f59c879 qemu_get_local_state_pathname relies on the > init_exec_dir, and virtiofsd asserts because we never set it. > Set it. > > Reported-by: Alex Bennée > Signed-off-by: Dr. David Alan Gilbert Queued > --- > tools/virtiofsd/passthrough_ll.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > index 0b229ebd57..cce983ca63 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -2839,6 +2839,8 @@ int main(int argc, char *argv[]) > /* Don't mask creation mode, kernel already did that */ > umask(0); > > + qemu_init_exec_dir(argv[0]); > + > pthread_mutex_init(&lo.mutex, NULL); > lo.inodes = g_hash_table_new(lo_key_hash, lo_key_equal); > lo.root.fd = -1; > -- > 2.26.2 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK