qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH  v1 02/22] hw/misc/mips_cpc: Start vCPU when powered on
Date: Wed,  7 Oct 2020 17:00:18 +0100	[thread overview]
Message-ID: <20201007160038.26953-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201007160038.26953-1-alex.bennee@linaro.org>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

In commit 102ca9667d we set "start-powered-off" on all vCPUs
included in the CPS (Coherent Processing System) but forgot to
start the vCPUS on when they are powered on in the CPC (Cluster
Power Controller).

This fixes the following tests:

  $ avocado run tests/acceptance/machine_mips_malta.py
   (1/3) test_mips_malta_i6400_framebuffer_logo_1core: PASS (3.67 s)
   (2/3) test_mips_malta_i6400_framebuffer_logo_7cores: INTERRUPTED: Test interrupted by SIGTERM (30.22 s)
   (3/3) test_mips_malta_i6400_framebuffer_logo_8cores: INTERRUPTED: Test interrupted by SIGTERM (30.25 s)
  RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | CANCEL 0

Fixes: 102ca9667d ("mips/cps: Use start-powered-off CPUState property")
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201007113942.2523866-1-f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 hw/misc/mips_cpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
index 2f7b2c9592..7c11fb3d44 100644
--- a/hw/misc/mips_cpc.c
+++ b/hw/misc/mips_cpc.c
@@ -38,6 +38,7 @@ static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
     MIPSCPCState *cpc = (MIPSCPCState *) data.host_ptr;
 
     cpu_reset(cs);
+    cs->halted = 0;
     cpc->vp_running |= 1ULL << cs->cpu_index;
 }
 
-- 
2.20.1



  parent reply	other threads:[~2020-10-07 16:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 16:00 [PATCH v1 00/22] testing and plugin fixes with gitdm updates (pre PR) Alex Bennée
2020-10-07 16:00 ` [PATCH v1 01/22] configure: fix performance regression due to PIC objects Alex Bennée
2020-10-07 16:00 ` Alex Bennée [this message]
2020-10-07 16:00 ` [PATCH v1 03/22] hw/ide: restore replay support of IDE Alex Bennée
2020-10-07 16:35   ` John Snow
2020-10-07 17:53   ` Philippe Mathieu-Daudé
2020-10-08 12:36   ` Richard Henderson
2020-10-07 16:00 ` [PATCH v1 04/22] cirrus: Fixing and speedup the msys2/mingw CI Alex Bennée
2020-10-07 16:00 ` [PATCH v1 05/22] cirrus: msys2/mingw speed is up, add excluded target back Alex Bennée
2020-10-07 16:00 ` [PATCH v1 06/22] tests/docker: Add genisoimage to the docker file Alex Bennée
2020-10-07 16:00 ` [PATCH v1 07/22] contrib/gitdm: Add more academic domains Alex Bennée
2020-10-07 16:00 ` [PATCH v1 08/22] contrib/gitdm: Add more individual contributors Alex Bennée
2020-10-07 16:00 ` [PATCH v1 09/22] contrib/gitdm: Add Baidu to the domain map Alex Bennée
2020-10-07 16:00 ` [PATCH v1 10/22] contrib/gitdm: Add ByteDance " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 11/22] contrib/gitdm: Add Google " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 12/22] contrib/gitdm: Add Nuvia " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 13/22] contrib/gitdm: Add Qualcomm " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 14/22] contrib/gitdm: Add Nir Soffer to Red Hat domain Alex Bennée
2020-10-07 16:00 ` [PATCH v1 15/22] contrib/gitdm: Add SUSE to the domain map Alex Bennée
2020-10-07 16:00 ` [PATCH v1 16/22] contrib/gitdm: Add Yadro " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 17/22] contrib/gitdm: Add Yandex " Alex Bennée
2020-10-07 16:00 ` [PATCH v1 18/22] .mailmap: Fix more contributor entries Alex Bennée
2020-10-07 16:00 ` [PATCH v1 19/22] plugins: Fixes a issue when dlsym failed, the handle not closed Alex Bennée
2020-10-07 16:00 ` [PATCH v1 20/22] plugin: Fixes compiling errors on msys2/mingw Alex Bennée
2020-10-07 16:00 ` [PATCH v1 21/22] cirrus: use V=1 when running tests on FreeBSD and macOS Alex Bennée
2020-10-08  1:31   ` Ed Maste
2020-10-07 16:00 ` [PATCH v1 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab Alex Bennée
2020-10-07 17:07   ` Willian Rampazzo
2020-10-08 14:55   ` Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007160038.26953-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).