From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH v3 0/4] qemu-storage-daemon: Remove QemuOpts from --object parser
Date: Wed, 7 Oct 2020 18:48:59 +0200 [thread overview]
Message-ID: <20201007164903.282198-1-kwolf@redhat.com> (raw)
This replaces the QemuOpts-based help code for --object in the storage
daemon with code based on the keyval parser.
v3:
- Always parse help options, no matter if the caller implements help or
not. If it doesn't, return an error. [Markus]
- Document changes to the keyval parser grammar [Markus]
- Support both 'help' and '?' [Eric]
- Test case fixes [Eric]
- Improved documentation of user_creatable_print_help(_from_qdict)
[Markus]
v2:
- Fixed double comma by reusing the existing key and value parsers [Eric]
- More tests to cover the additional cases
Kevin Wolf (4):
keyval: Parse help options
qom: Factor out helpers from user_creatable_print_help()
qom: Add user_creatable_print_help_from_qdict()
qemu-storage-daemon: Remove QemuOpts from --object parser
include/qemu/help_option.h | 5 +
include/qemu/option.h | 2 +-
include/qom/object_interfaces.h | 21 ++-
qapi/qobject-input-visitor.c | 2 +-
qom/object_interfaces.c | 99 ++++++++-----
storage-daemon/qemu-storage-daemon.c | 15 +-
tests/test-keyval.c | 205 +++++++++++++++++++--------
util/keyval.c | 54 ++++++-
8 files changed, 280 insertions(+), 123 deletions(-)
--
2.25.4
next reply other threads:[~2020-10-07 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 16:48 Kevin Wolf [this message]
2020-10-07 16:49 ` [PATCH v3 1/4] keyval: Parse help options Kevin Wolf
2020-10-07 17:29 ` Eric Blake
2020-10-08 8:45 ` Kevin Wolf
2020-10-08 15:25 ` Markus Armbruster
2020-10-09 15:10 ` Markus Armbruster
2020-10-07 16:49 ` [PATCH v3 2/4] qom: Factor out helpers from user_creatable_print_help() Kevin Wolf
2020-10-07 16:49 ` [PATCH v3 3/4] qom: Add user_creatable_print_help_from_qdict() Kevin Wolf
2020-10-07 16:49 ` [PATCH v3 4/4] qemu-storage-daemon: Remove QemuOpts from --object parser Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007164903.282198-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).