From: Stefan Hajnoczi <stefanha@redhat.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level
Date: Thu, 8 Oct 2020 16:09:43 +0100 [thread overview]
Message-ID: <20201008150943.GA31472@stefanha-x1.localdomain> (raw)
In-Reply-To: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Thu, Oct 08, 2020 at 08:01:48PM +0900, Misono Tomohiro wrote:
> Just noticed that although help message says default log level is INFO,
> it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
> It's better to follow help message.
>
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
I checked that FUSE_LOG_INFO isn't used in the main request code path.
Therefore this change shouldn't cause a lot of new log output or affect
performance:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-08 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 11:01 [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Misono Tomohiro
2020-10-08 15:09 ` Stefan Hajnoczi [this message]
2020-10-26 17:13 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008150943.GA31472@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).