qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, alex.bennee@linaro.org,
	zhengchuan@huawei.com, stefanha@redhat.com, peterx@redhat.com
Cc: quintela@redhat.com
Subject: [PULL 05/10] migration: Pass incoming state into qemu_ufd_copy_ioctl()
Date: Thu,  8 Oct 2020 20:10:41 +0100	[thread overview]
Message-ID: <20201008191046.272549-6-dgilbert@redhat.com> (raw)
In-Reply-To: <20201008191046.272549-1-dgilbert@redhat.com>

From: Peter Xu <peterx@redhat.com>

It'll be used in follow up patches to access more fields out of it.  Meanwhile
fetch the userfaultfd inside the function.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20201002175336.30858-2-peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/postcopy-ram.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 0a2f88a87d..722034dc01 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -1128,10 +1128,12 @@ int postcopy_ram_incoming_setup(MigrationIncomingState *mis)
     return 0;
 }
 
-static int qemu_ufd_copy_ioctl(int userfault_fd, void *host_addr,
+static int qemu_ufd_copy_ioctl(MigrationIncomingState *mis, void *host_addr,
                                void *from_addr, uint64_t pagesize, RAMBlock *rb)
 {
+    int userfault_fd = mis->userfault_fd;
     int ret;
+
     if (from_addr) {
         struct uffdio_copy copy_struct;
         copy_struct.dst = (uint64_t)(uintptr_t)host_addr;
@@ -1185,7 +1187,7 @@ int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from,
      * which would be slightly cheaper, but we'd have to be careful
      * of the order of updating our page state.
      */
-    if (qemu_ufd_copy_ioctl(mis->userfault_fd, host, from, pagesize, rb)) {
+    if (qemu_ufd_copy_ioctl(mis, host, from, pagesize, rb)) {
         int e = errno;
         error_report("%s: %s copy host: %p from: %p (size: %zd)",
                      __func__, strerror(e), host, from, pagesize);
@@ -1212,7 +1214,7 @@ int postcopy_place_page_zero(MigrationIncomingState *mis, void *host,
      * but it's not available for everything (e.g. hugetlbpages)
      */
     if (qemu_ram_is_uf_zeroable(rb)) {
-        if (qemu_ufd_copy_ioctl(mis->userfault_fd, host, NULL, pagesize, rb)) {
+        if (qemu_ufd_copy_ioctl(mis, host, NULL, pagesize, rb)) {
             int e = errno;
             error_report("%s: %s zero host: %p",
                          __func__, strerror(e), host);
-- 
2.28.0



  parent reply	other threads:[~2020-10-08 19:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 19:10 [PULL 00/10] migration queue Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 01/10] virtiofsd: Silence gcc warning Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 02/10] tools/virtiofsd: add support for --socket-group Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 03/10] virtiofsd: Call qemu_init_exec_dir Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 04/10] virtiofsd: avoid /proc/self/fd tempdir Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` Dr. David Alan Gilbert (git) [this message]
2020-10-08 19:10 ` [PULL 06/10] migration: Introduce migrate_send_rp_message_req_pages() Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 07/10] migration: Maintain postcopy faulted addresses Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 08/10] migration: Sync requested pages after postcopy recovery Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 09/10] migration/dirtyrate: record start_time and calc_time while at the measuring state Dr. David Alan Gilbert (git)
2020-10-08 19:10 ` [PULL 10/10] migration/dirtyrate: present dirty rate only when querying the rate has completed Dr. David Alan Gilbert (git)
2020-10-11 18:29 ` [PULL 00/10] migration queue Peter Maydell
2020-10-12  8:12   ` Dr. David Alan Gilbert
2020-10-14 20:01   ` Peter Xu
2020-10-15  9:13     ` Thomas Huth
2020-10-15 18:58       ` Peter Xu
  -- strict thread matches above, loose matches on Subject: below --
2020-10-07 15:55 Dr. David Alan Gilbert (git)
2020-10-07 15:55 ` [PULL 05/10] migration: Pass incoming state into qemu_ufd_copy_ioctl() Dr. David Alan Gilbert (git)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008191046.272549-6-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=zhengchuan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).