Re: [PATCH 2/5] Fixing Lesser GPL version number [2/5]

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Oct 09, 2020 at 06:39:34AM +0000, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Public License. It is
> either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all
> occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section.
> Also, It came to notice that some of the files that were edited for the change
> were not following latest comment rules. For example using "//" to mark comment
> instead of "/*". That is also fixed in this patch.
> 
> This patch is divided in 5 parts, directory wise, in order to make reviewing process easier.
> Below listed are the parts of the patch, where asterisk denotes the part you are currently viewing.
> 
> 	[ ] Files in authz/backends/block/linux-user/tests/migration directory (82 Files)
> 	[*] Files in hw/include/disas (100 files)
> 	[ ] Files inside target/ 'alpha,arm,cris,hppa,i386' (96 files)
> 	[ ] Files inside target/ 'lm32,microblaze,mips,ppc,rx,sparc,tilegx,tricore,xtensa' (63 files)
> 	[ ] Files in ui/util/include/scripts and QEMU root directory (76 Files)
> 
> Below is how the license version was corrected:
> 
> 1. To find the number of file having "Lesser GPL version 2 ":
> 	grep -l Lesser $(grep -rl "version 2 " * ) > result.dat
>    Total of 417 files were found (After manually exluding the files like COPYING and COPYING.LIB from the result)
> 
> 2. To find the number of occurences of "version 2 " in the resulted files:
> 	egrep -c "version 2 " $(cat result.dat)
>    410 files had "version 2" occurence 1 time (name of those files was saved in one_timers.dat)
>    and in 7 files "version 2" occurences were multiple times.
> 
> 3. Files having occurence exactly 1 time were corrected using below command:
> 	sed -i "s/version 2 /version 2.1 /g" $(cat one_timers.dat)
>    For rest of 7 files, correction was done manually.
> 
> Note:
> During validating this patch (2/5), It was noticed that "hw/i2c/mpc_i2c.c" file had below license text mentioned:
> "You should have received a copy of the GNU Lesser General Public"
> But the file was actually using "GNU General Public License, version 2 or later," which was confusing
> so I've not included the that change in this patch. So in fact, only 99 files are changed in this patch.
> 
> Signed-off-by: Chetan Pant <chetan4windows@gmail.com>
> ---

>  io/channel-buffer.c                   |  2 +-
>  io/channel-command.c                  |  2 +-
>  io/channel-file.c                     |  2 +-
>  io/channel-socket.c                   |  2 +-
>  io/channel-tls.c                      |  2 +-
>  io/channel-util.c                     |  2 +-
>  io/channel-watch.c                    |  2 +-
>  io/channel-websock.c                  |  2 +-
>  io/channel.c                          |  2 +-
>  io/dns-resolver.c                     |  2 +-
>  io/task.c                             |  2 +-

I'll queue these if you combine them with the "io" pieces from
patch 1.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|