From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3
Date: Fri, 9 Oct 2020 13:51:20 -0400 [thread overview]
Message-ID: <20201009175123.249009-1-jsnow@redhat.com> (raw)
This is actually quite short; it's already fully typed. Attached are two
fixes for settimeout and error handling. There are actually more fixes
that need to be made here, because use of readline() in non-blocking
mode is actually undefined behavior, so a more thorough re-work of the
error classes used by this library must be put on hold pending a more
aggressive re-write.
That's a problem for later, so for now, call the initial conversion to
the statically typed subset of python done so we can move on to adding
the regression tests that will maintain this baseline for us.
John Snow (3):
python: add mypy config
python/qemu/qmp.py: re-raise OSError when encountered
python/qemu/qmp.py: Fix settimeout operation
python/mypy.ini | 4 ++++
python/qemu/qmp.py | 30 +++++++++++++++++++++---------
2 files changed, 25 insertions(+), 9 deletions(-)
create mode 100644 python/mypy.ini
--
2.26.2
next reply other threads:[~2020-10-09 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 17:51 John Snow [this message]
2020-10-09 17:51 ` [PATCH 1/3] python: add mypy config John Snow
2020-10-13 9:15 ` Bin Meng
2020-10-13 17:00 ` John Snow
2020-10-09 17:51 ` [PATCH 2/3] python/qemu/qmp.py: re-raise OSError when encountered John Snow
2020-10-09 19:34 ` Philippe Mathieu-Daudé
2020-10-09 17:51 ` [PATCH 3/3] python/qemu/qmp.py: Fix settimeout operation John Snow
2020-10-09 19:35 ` Philippe Mathieu-Daudé
2020-10-09 17:52 ` [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3 John Snow
2020-10-12 14:54 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009175123.249009-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).