From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH 2/3] qom: Make object_property_add_uint*_ptr() get non-const pointers
Date: Fri, 9 Oct 2020 15:15:19 -0400 [thread overview]
Message-ID: <20201009191520.1799419-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20201009191520.1799419-1-ehabkost@redhat.com>
Currently, the getter/setter functions are awkward because the
visit_type_uint*() functions provided by QAPI will always write a
value to the provided pointer. Getting a non-const pointer will
allow us to simplify a lot of the getters/setters logic.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/qom/object.h | 8 ++++----
qom/object.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index a124cf897d..1441807be6 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1744,7 +1744,7 @@ typedef enum {
* Returns: The newly added property on success, or %NULL on failure.
*/
ObjectProperty *object_property_add_uint8_ptr(Object *obj, const char *name,
- const uint8_t *v,
+ uint8_t *v,
ObjectPropertyFlags flags);
ObjectProperty *object_class_property_add_uint8_ptr(ObjectClass *klass,
@@ -1765,7 +1765,7 @@ ObjectProperty *object_class_property_add_uint8_ptr(ObjectClass *klass,
* Returns: The newly added property on success, or %NULL on failure.
*/
ObjectProperty *object_property_add_uint16_ptr(Object *obj, const char *name,
- const uint16_t *v,
+ uint16_t *v,
ObjectPropertyFlags flags);
ObjectProperty *object_class_property_add_uint16_ptr(ObjectClass *klass,
@@ -1786,7 +1786,7 @@ ObjectProperty *object_class_property_add_uint16_ptr(ObjectClass *klass,
* Returns: The newly added property on success, or %NULL on failure.
*/
ObjectProperty *object_property_add_uint32_ptr(Object *obj, const char *name,
- const uint32_t *v,
+ uint32_t *v,
ObjectPropertyFlags flags);
ObjectProperty *object_class_property_add_uint32_ptr(ObjectClass *klass,
@@ -1807,7 +1807,7 @@ ObjectProperty *object_class_property_add_uint32_ptr(ObjectClass *klass,
* Returns: The newly added property on success, or %NULL on failure.
*/
ObjectProperty *object_property_add_uint64_ptr(Object *obj, const char *name,
- const uint64_t *v,
+ uint64_t *v,
ObjectPropertyFlags flags);
ObjectProperty *object_class_property_add_uint64_ptr(ObjectClass *klass,
diff --git a/qom/object.c b/qom/object.c
index 73f27b8b7e..6b4dfc279a 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -2623,7 +2623,7 @@ object_class_property_add_uint_ptr(ObjectClass *oc, const char *name,
ObjectProperty *
object_property_add_uint8_ptr(Object *obj, const char *name,
- const uint8_t *v,
+ uint8_t *v,
ObjectPropertyFlags flags)
{
return object_property_add_uint_ptr(obj, name, "uint8",
@@ -2646,7 +2646,7 @@ object_class_property_add_uint8_ptr(ObjectClass *klass, const char *name,
ObjectProperty *
object_property_add_uint16_ptr(Object *obj, const char *name,
- const uint16_t *v,
+ uint16_t *v,
ObjectPropertyFlags flags)
{
return object_property_add_uint_ptr(obj, name, "uint16",
@@ -2669,7 +2669,7 @@ object_class_property_add_uint16_ptr(ObjectClass *klass, const char *name,
ObjectProperty *
object_property_add_uint32_ptr(Object *obj, const char *name,
- const uint32_t *v,
+ uint32_t *v,
ObjectPropertyFlags flags)
{
return object_property_add_uint_ptr(obj, name, "uint32",
@@ -2692,7 +2692,7 @@ object_class_property_add_uint32_ptr(ObjectClass *klass, const char *name,
ObjectProperty *
object_property_add_uint64_ptr(Object *obj, const char *name,
- const uint64_t *v,
+ uint64_t *v,
ObjectPropertyFlags flags)
{
return object_property_add_uint_ptr(obj, name, "uint64",
--
2.26.2
next prev parent reply other threads:[~2020-10-09 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 19:15 [PATCH 0/3] qom: Simplify pointer property getters/setters Eduardo Habkost
2020-10-09 19:15 ` [PATCH 1/3] acpi: Don't pass const pointers to object_property_add_uint*_ptr() Eduardo Habkost
2020-10-09 19:15 ` Eduardo Habkost [this message]
2020-10-09 19:15 ` [PATCH 3/3] qom: Simplify and merge pointer property getters/setters Eduardo Habkost
2020-10-09 20:02 ` Eric Blake
2020-10-09 20:09 ` fixup! " Eduardo Habkost
2020-10-21 13:09 ` [PATCH 0/3] qom: Simplify " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009191520.1799419-3-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).