From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F803C433DF for ; Mon, 12 Oct 2020 14:43:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13D7C20776 for ; Mon, 12 Oct 2020 14:43:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HA5ST8Ot" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13D7C20776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRz3I-0001SX-4R for qemu-devel@archiver.kernel.org; Mon, 12 Oct 2020 10:43:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRyys-0004la-DB for qemu-devel@nongnu.org; Mon, 12 Oct 2020 10:39:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kRyyq-0007nt-TO for qemu-devel@nongnu.org; Mon, 12 Oct 2020 10:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602513555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SFrfekwEwcDiAf8lhqy4vACmp18EBZJ09zHCP+Iqvqs=; b=HA5ST8Ot00umezseFFmgbrAuZF6jlM0kEyzc5tY9iXD4IuAkWHWJfjFLikZQy1kBzmsYNr wfB9obxVEOfZP4qL/nW9pbt7TsjTk0XIGE+2J8nkpS6hJ6VY+2QfCil+g4lIKtBBpgggH8 +/GMeONlWo5uShbQirbtbnWlPMARNqc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-EO6izVPPOLe0CjmpKz3C-A-1; Mon, 12 Oct 2020 10:39:12 -0400 X-MC-Unique: EO6izVPPOLe0CjmpKz3C-A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E38418CB72C; Mon, 12 Oct 2020 14:39:11 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-24.ams2.redhat.com [10.36.114.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 565D91051D; Mon, 12 Oct 2020 14:39:10 +0000 (UTC) Date: Mon, 12 Oct 2020 16:39:08 +0200 From: Kevin Wolf To: Markus Armbruster Subject: Re: [PATCH v4 0/7] qemu-storage-daemon: Remove QemuOpts from --object Message-ID: <20201012143908.GF7777@merkur.fritz.box> References: <20201011073505.1185335-1-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201011073505.1185335-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/12 02:58:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 11.10.2020 um 09:34 hat Markus Armbruster geschrieben: > This replaces the QemuOpts-based help code for --object in the storage > daemon with code based on the keyval parser. > > Review of v3 led me to preexisting issues. Instead of posting my > fixes separately, then working with Kevin to rebase his work on top of > mine, I did the rebase myself and am posting it together with my fixes > as v4. Hope that's okay. > > Note: to test qemu-storage-daemon --object help, you need Philippe's > "[PATCH v3] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE" > and its prerequisites (first 10 patches of Paolo's "[PULL 00/39] SCSI, > qdev, qtest, meson patches for 2020-10-10"), so it doesn't crash with > "missing interface 'fw_cfg-data-generator' for object 'tls-creds'". Thanks, fixed up the typos in patch 4 and applied patches 1-4. I'm taking patches 5-7 from my original series because you didn't add your S-o-b (they are unchanged anyway, so no practical difference). Kevin