From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] scripts: display how long each test takes to execute
Date: Mon, 12 Oct 2020 16:09:16 +0100 [thread overview]
Message-ID: <20201012150916.GJ39408@redhat.com> (raw)
In-Reply-To: <fa7c5d50-cfc5-78c2-edf9-416231322f81@redhat.com>
On Mon, Oct 12, 2020 at 05:07:18PM +0200, Thomas Huth wrote:
> On 14/09/2020 13.09, Daniel P. Berrangé wrote:
> > Sometimes under CI tests non-deterministically take longer to execute
> > than expected which can trigger timeouts. It is almost impossible to
> > diagnose this though without seeing execution time for each test case.
> >
> > With this change, when passing "V=1" to make, we get a duration printed
> > at test completion:
> >
> > $ make check V=1
> > ...snip...
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/home/berrange/src/virt/qemu/tests/dbus-vmstate-daemon.sh QTEST_QEMU_BINARY=./qemu-system-x86_64 tests/qtest/migration-test --tap -k
> > PASS 1 qtest-x86_64: migration-test /x86_64/migration/deprecated
> > PASS 2 qtest-x86_64: migration-test /x86_64/migration/bad_dest
> > PASS 3 qtest-x86_64: migration-test /x86_64/migration/fd_proto
> > PASS 4 qtest-x86_64: migration-test /x86_64/migration/validate_uuid
> > PASS 5 qtest-x86_64: migration-test /x86_64/migration/validate_uuid_error
> > PASS 6 qtest-x86_64: migration-test /x86_64/migration/validate_uuid_src_not_set
> > PASS 7 qtest-x86_64: migration-test /x86_64/migration/validate_uuid_dst_not_set
> > PASS 8 qtest-x86_64: migration-test /x86_64/migration/auto_converge
> > PASS 9 qtest-x86_64: migration-test /x86_64/migration/postcopy/unix
> > PASS 10 qtest-x86_64: migration-test /x86_64/migration/postcopy/recovery
> > PASS 11 qtest-x86_64: migration-test /x86_64/migration/precopy/unix
> > PASS 12 qtest-x86_64: migration-test /x86_64/migration/precopy/tcp
> > PASS 13 qtest-x86_64: migration-test /x86_64/migration/xbzrle/unix
> > PASS 14 qtest-x86_64: migration-test /x86_64/migration/multifd/tcp/none
> > PASS 15 qtest-x86_64: migration-test /x86_64/migration/multifd/tcp/cancel
> > PASS 16 qtest-x86_64: migration-test /x86_64/migration/multifd/tcp/zlib
> > TIME 28 seconds
>
> If I run "make check -j8" in parallel, it's quite hard to match the "TIME xx
> seconds" lines with the corresponding tests... so could you please in
> include the test name in the output there?
I wasn't intending to update this given paolo's negative response to
the patch.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-12 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:09 [PATCH] scripts: display how long each test takes to execute Daniel P. Berrangé
2020-09-14 11:15 ` no-reply
2020-09-14 11:19 ` Paolo Bonzini
2020-09-14 11:33 ` Daniel P. Berrangé
2020-09-14 12:01 ` Paolo Bonzini
2020-10-12 15:07 ` Thomas Huth
2020-10-12 15:09 ` Daniel P. Berrangé [this message]
2020-10-12 15:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012150916.GJ39408@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).