Re: [PATCH] qemu-edid: drop cast

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> Not needed and makes some compilers error out with:
> 
> qemu-edid.c:15:1: error: initializer element is not constant

Which compilers do this. If we're not seeing this failure in our
CI, then we have a CI gap that likely needs filling.

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-edid.c b/qemu-edid.c
> index 1db3372b982c..1cd6a9517238 100644
> --- a/qemu-edid.c
> +++ b/qemu-edid.c
> @@ -9,7 +9,7 @@
>  #include "qemu/cutils.h"
>  #include "hw/display/edid.h"
>  
> -static qemu_edid_info info = (qemu_edid_info) {
> +static qemu_edid_info info = {
>      .prefx = 1024,
>      .prefy = 768,
>  };
> -- 
> 2.27.0
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|