From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-edid: drop cast
Date: Tue, 13 Oct 2020 11:40:52 +0100 [thread overview]
Message-ID: <20201013104052.GJ70612@redhat.com> (raw)
In-Reply-To: <20201013103446.ahhhplg5mwpppk7o@sirius.home.kraxel.org>
On Tue, Oct 13, 2020 at 12:34:46PM +0200, Gerd Hoffmann wrote:
> On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> > > Not needed and makes some compilers error out with:
> > >
> > > qemu-edid.c:15:1: error: initializer element is not constant
> >
> > Which compilers do this. If we're not seeing this failure in our
> > CI, then we have a CI gap that likely needs filling.
>
> x86_64-w64-mingw32-gcc (GCC) 4.9.3 20150626 (Fedora MinGW 4.9.3-1.el7)
Oh, that's a really ancient mingw toolchain. Officially we only care
about current generation mingw toolchains ad don't try to support old
ones. Effectively this means whatever mingw is in current shipping
Fedora or MXE releases.
The fix is fine, but we don't need to worry about adding this CI after
all since its an unsupported platform.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-10-13 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:16 [PATCH] qemu-edid: drop cast Gerd Hoffmann
2020-10-13 9:23 ` Daniel P. Berrangé
2020-10-13 10:34 ` Gerd Hoffmann
2020-10-13 10:40 ` Daniel P. Berrangé [this message]
2020-10-13 10:41 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013104052.GJ70612@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).