From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Elena Afanasova <eafanasova@gmail.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 09/14] block/blkdebug: fix memory leak
Date: Tue, 13 Oct 2020 13:50:47 +0200 [thread overview]
Message-ID: <20201013115052.133355-10-laurent@vivier.eu> (raw)
In-Reply-To: <20201013115052.133355-1-laurent@vivier.eu>
From: Elena Afanasova <eafanasova@gmail.com>
Spotted by PVS-Studio
Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1e903f928eb3da332cc95e2a6f87243bd9fe66e4.camel@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
block/blkdebug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index eecbf3e5c479..54da719dd151 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp)
BLKDEBUG_IO_TYPE__MAX, &local_error);
if (local_error) {
error_propagate(errp, local_error);
+ g_free(rule);
return -1;
}
if (iotype != BLKDEBUG_IO_TYPE__MAX) {
--
2.26.2
next prev parent reply other threads:[~2020-10-13 12:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 11:50 [PULL 00/14] Trivial branch for 5.2 patches Laurent Vivier
2020-10-13 11:50 ` [PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo Laurent Vivier
2020-10-13 11:50 ` [PULL 02/14] target/i386/cpu: " Laurent Vivier
2020-10-13 11:50 ` [PULL 03/14] hw/block/nvme: Simplify timestamp sum Laurent Vivier
2020-10-13 11:50 ` [PULL 04/14] tests/test-char: Use a proper fallthrough comment Laurent Vivier
2020-10-13 11:50 ` [PULL 05/14] vmdk: fix maybe uninitialized warnings Laurent Vivier
2020-10-13 11:50 ` [PULL 06/14] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties() Laurent Vivier
2020-10-13 11:50 ` [PULL 07/14] softmmu/memory: Log invalid memory accesses Laurent Vivier
2020-10-13 11:50 ` [PULL 08/14] hw/pci: Fix typo in PCI hot-plug error message Laurent Vivier
2020-10-13 11:50 ` Laurent Vivier [this message]
2020-10-13 11:50 ` [PULL 10/14] hw/char/serial: remove duplicate .class_init in serial_mm_info Laurent Vivier
2020-10-13 11:50 ` [PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN Laurent Vivier
2020-10-13 11:50 ` [PULL 12/14] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry Laurent Vivier
2020-10-13 11:50 ` [PULL 13/14] mingw: fix error __USE_MINGW_ANSI_STDIO redefined Laurent Vivier
2020-10-13 11:50 ` [PULL 14/14] meson.build: drop duplicate 'sparc64' entry Laurent Vivier
2020-10-13 13:53 ` [PULL 00/14] Trivial branch for 5.2 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013115052.133355-10-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=eafanasova@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).