From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
qemu-trivial@nongnu.org, Anup.Patel@wdc.com,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
Alistair Francis <alistair.francis@wdc.com>
Subject: [PULL 11/14] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN
Date: Tue, 13 Oct 2020 13:50:49 +0200 [thread overview]
Message-ID: <20201013115052.133355-12-laurent@vivier.eu> (raw)
In-Reply-To: <20201013115052.133355-1-laurent@vivier.eu>
From: Laurent Vivier <lvivier@redhat.com>
The doc [1] doesn't define the endianness, but the kernel driver
uses readl() to access the registers, so we can guess it depends
on the architecture endianness.
As riscv architecture endianness is little it might not change anything
for it.
Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]
[1] https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177
Fixes: 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
Cc: Anup.Patel@wdc.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20201009113843.60995-2-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/rtc/goldfish_rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rtc/goldfish_rtc.c b/hw/rtc/goldfish_rtc.c
index 6ddd45cce039..0f4e8185a796 100644
--- a/hw/rtc/goldfish_rtc.c
+++ b/hw/rtc/goldfish_rtc.c
@@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int version_id)
static const MemoryRegionOps goldfish_rtc_ops = {
.read = goldfish_rtc_read,
.write = goldfish_rtc_write,
- .endianness = DEVICE_LITTLE_ENDIAN,
+ .endianness = DEVICE_NATIVE_ENDIAN,
.valid = {
.min_access_size = 4,
.max_access_size = 4
--
2.26.2
next prev parent reply other threads:[~2020-10-13 12:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 11:50 [PULL 00/14] Trivial branch for 5.2 patches Laurent Vivier
2020-10-13 11:50 ` [PULL 01/14] qemu-img-cmds.hx: Update comment that mentions Texinfo Laurent Vivier
2020-10-13 11:50 ` [PULL 02/14] target/i386/cpu: " Laurent Vivier
2020-10-13 11:50 ` [PULL 03/14] hw/block/nvme: Simplify timestamp sum Laurent Vivier
2020-10-13 11:50 ` [PULL 04/14] tests/test-char: Use a proper fallthrough comment Laurent Vivier
2020-10-13 11:50 ` [PULL 05/14] vmdk: fix maybe uninitialized warnings Laurent Vivier
2020-10-13 11:50 ` [PULL 06/14] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties() Laurent Vivier
2020-10-13 11:50 ` [PULL 07/14] softmmu/memory: Log invalid memory accesses Laurent Vivier
2020-10-13 11:50 ` [PULL 08/14] hw/pci: Fix typo in PCI hot-plug error message Laurent Vivier
2020-10-13 11:50 ` [PULL 09/14] block/blkdebug: fix memory leak Laurent Vivier
2020-10-13 11:50 ` [PULL 10/14] hw/char/serial: remove duplicate .class_init in serial_mm_info Laurent Vivier
2020-10-13 11:50 ` Laurent Vivier [this message]
2020-10-13 11:50 ` [PULL 12/14] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry Laurent Vivier
2020-10-13 11:50 ` [PULL 13/14] mingw: fix error __USE_MINGW_ANSI_STDIO redefined Laurent Vivier
2020-10-13 11:50 ` [PULL 14/14] meson.build: drop duplicate 'sparc64' entry Laurent Vivier
2020-10-13 13:53 ` [PULL 00/14] Trivial branch for 5.2 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013115052.133355-12-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=Anup.Patel@wdc.com \
--cc=alistair.francis@wdc.com \
--cc=lvivier@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).