qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <cfontana@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Pavel Dovgalyuk" <dovgaluk@ispras.ru>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v3 0/3] unbreak non-tcg builds
Date: Tue, 13 Oct 2020 16:38:03 +0200	[thread overview]
Message-ID: <20201013143806.14321-1-cfontana@suse.de> (raw)

This series now unbreaks current non-tcg builds
(!CONFIG_TCG).

tests Makefiles need to avoid relying on all non-native
archs binaries to be present,

bios-tables-test needs to skip tests that are tcg-only,

and notably the replay framework needs to consider that
it might not be functional (or its code present at all)
without TCG.

Tested ok target x86_64-softmmu on x86_64 host with:

./configure --enable-tcg --disable-kvm
./configure --enable-kvm --disable-tcg
./configure --enable-tcg --enable-kvm

running make check-qtest

v2 => v3:

* do not alter the replay api, provide a block wrapper
instead to call into replay events handling
or the normal call flow depending on whether replay events are enabled.

v1: initial RFC


Claudio Fontana (2):
  qtest: unbreak non-TCG builds in bios-tables-test
  replay: do not build if TCG is not available

Paolo Bonzini (1):
  tests/Makefile.include: unbreak non-tcg builds

 block/block-backend.c          |  9 ++--
 block/io.c                     | 52 ++++++++++++------
 block/iscsi.c                  |  5 +-
 block/meson.build              |  3 +-
 block/nfs.c                    |  6 +--
 block/null.c                   |  4 +-
 block/nvme.c                   |  6 +--
 block/rbd.c                    |  5 +-
 hw/ide/core.c                  |  8 +--
 hw/ide/ioport.c                |  1 -
 include/block/block.h          | 29 ++++++++++
 migration/savevm.c             | 11 ++--
 net/meson.build                |  3 +-
 replay/meson.build             |  2 +-
 replay/replay-events.c         | 20 +++----
 replay/replay-input.c          |  4 +-
 stubs/meson.build              |  1 -
 stubs/replay-user.c            |  9 ----
 stubs/replay.c                 | 96 ++++++++++++++++++++++++++++++++++
 tests/Makefile.include         |  2 +-
 tests/ptimer-test-stubs.c      |  5 --
 tests/qtest/bios-tables-test.c | 10 ++++
 tests/qtest/qmp-cmd-test.c     |  3 ++
 ui/input.c                     | 12 ++++-
 24 files changed, 223 insertions(+), 83 deletions(-)
 delete mode 100644 stubs/replay-user.c

-- 
2.26.2



             reply	other threads:[~2020-10-13 14:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 14:38 Claudio Fontana [this message]
2020-10-13 14:38 ` [PATCH v3 1/3] tests/Makefile.include: unbreak non-tcg builds Claudio Fontana
2020-10-13 14:38 ` [PATCH v3 2/3] qtest: unbreak non-TCG builds in bios-tables-test Claudio Fontana
2020-10-13 14:38 ` [PATCH v3 3/3] replay: do not build if TCG is not available Claudio Fontana
2020-10-13 17:12   ` Paolo Bonzini
2020-10-13 17:17     ` Claudio Fontana
2020-10-13 17:25       ` Paolo Bonzini
2020-10-13 17:37         ` Claudio Fontana
2020-10-13 14:55 ` [PATCH v3 0/3] unbreak non-tcg builds Philippe Mathieu-Daudé
2020-10-13 16:47   ` Claudio Fontana
2020-10-13 16:51     ` Daniel P. Berrangé
2020-10-26 15:28   ` Claudio Fontana
2020-10-26 15:34     ` Claudio Fontana
2021-01-10 17:51   ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013143806.14321-1-cfontana@suse.de \
    --to=cfontana@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).