From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17FD6C433E7 for ; Tue, 13 Oct 2020 18:02:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E4172539D for ; Tue, 13 Oct 2020 18:02:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VT39qnP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E4172539D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSOdJ-0005v2-4U for qemu-devel@archiver.kernel.org; Tue, 13 Oct 2020 14:02:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSOcH-0005Pp-8F for qemu-devel@nongnu.org; Tue, 13 Oct 2020 14:01:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kSOcC-0006BQ-UO for qemu-devel@nongnu.org; Tue, 13 Oct 2020 14:01:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602612089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TCf6YpfBLWSZWrILkN6p7RKHfRZRQmHyHL/7+c+QFD4=; b=VT39qnP1EL6ikRZbIN3qrZfGKFehzBmCqyu1x5gaumiQaHgSrJCwn9g9IZ1hABFagQlM9G oYNCoQG+dN0+nUQh96+qCrR/sQB5taIcuHZSuOGYLkN6L7dgnEptgh3AlqHXpckKUQo98o ERkShD/ixAMFaBw6CzFDRxNGoSQxk3A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-5M7z6mIDPzWqxrXp5faXKA-1; Tue, 13 Oct 2020 14:01:26 -0400 X-MC-Unique: 5M7z6mIDPzWqxrXp5faXKA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8F15879526 for ; Tue, 13 Oct 2020 18:01:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-119-55.rdu2.redhat.com [10.10.119.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 962B339F; Tue, 13 Oct 2020 18:01:22 +0000 (UTC) Date: Tue, 13 Oct 2020 14:01:20 -0400 From: Cleber Rosa To: Eduardo Habkost Subject: Re: [PATCH v2] tests/acceptance: Test case for detecting -object crashes Message-ID: <20201013180120.GB1065819@localhost.localdomain> References: <20201009202905.1845802-1-ehabkost@redhat.com> <8daa726a-a359-c533-acb0-e3294b4c8aa7@redhat.com> <20201012031859.GC887538@localhost.localdomain> <20201013174611.GA5733@habkost.net> MIME-Version: 1.0 In-Reply-To: <20201013174611.GA5733@habkost.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yEPQxsgoJgBvi8ip" Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/13 03:04:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --yEPQxsgoJgBvi8ip Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 13, 2020 at 01:46:11PM -0400, Eduardo Habkost wrote: > On Sun, Oct 11, 2020 at 11:18:59PM -0400, Cleber Rosa wrote: > > On Sat, Oct 10, 2020 at 09:54:16AM +0200, Philippe Mathieu-Daud=E9 wrot= e: > > > On 10/9/20 10:29 PM, Eduardo Habkost wrote: > > > > Add a simple test case that will run QEMU directly (without QMP) > > > > just to check for crashes when using `-object`. > > > >=20 > > > > Signed-off-by: Eduardo Habkost > > > > --- > > > > Changes v1 -> v2: > > > > * "Running command:" log message instead of "Command:" (Cleber) > > > > * Use universal_newlines=3DTrue instead of encoding=3D'utf-8' (Cleb= er) > > > > * Rename devices() to get_devices() (Cleber) > > > > * Use @avocado.fail_on(subprocess.CalledProcessError) (Cleber) > > > > * Reword test_crash() docstring (Cleber) > > > > * Reorder imports > > >=20 > > > Assuming: > > > Based-on: <20201008202713.1416823-1-ehabkost@redhat.com> > > >=20 > > > I get: > > >=20 > > > (1/2) tests/acceptance/object_option.py:ObjectOption.test_help: > > > qemu-system-avr: No machine specified, and there is no default > > > Use -machine help to list supported machines > > > FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help'])= (0.19 > > > s) > > > (2/2) tests/acceptance/object_option.py:ObjectOption.test_crash: > > > qemu-system-avr: No machine specified, and there is no default > > > Use -machine help to list supported machines > > > FAIL: CalledProcessError(1, ['./qemu-system-avr', '-object', 'help'])= (0.18 > > > s) > > > > >=20 > > Did you influence (test parameter?) the QEMU binary to be used? >=20 > I'm assuming this was triggered by "make check-acceptance". I The output shows test 1/2 and 2/2, so I don't think it was triggered by "make check-acceptance". > will change the test case to use '-machine none', which should > work on all architectures. > +1, sounds good! - Cleber. > --=20 > Eduardo --yEPQxsgoJgBvi8ip Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeruW64tGuU1eD+m7ZX6NM6XyCfMFAl+F63AACgkQZX6NM6Xy CfO/7Q//cn8DZowN25LS3WeWHfFQA6buVlK84GH/PQ9zfCyNgoL93iNRVmeWkHai Z5CtZWdFgjsPwKxe8SgpWnZV5R7J7HhvspIfo+miMoxulja/dOydHEhu82P51rQy pIqtKsO0AFzAgaMWL6y2yOPp9mf9BCO9u/POrg1Cd2y0M+V13JAymo+eY+Hb7dnO +r+7rkXdsSa6VS+WazDoL6lOayjnreLL8lTcGRffcY9TWwm+DWzXOZS0C5e+0P2g Jnx0qTOlz5ASUKTPEXnizzRnjJgmWCAx1aKkAhnZ2YfjyLIXm5FEcG+2V18P6WZq xRmHmpPfN7UKn36o5qvRGv34m3yVuNq64uQectHIAoPE692jOOkAJKMp5FLyko7p ilsROkTVOE9qkXsNHydzhSQwKQ7sYr6p1RAwfsWcFdnRsgpf1OMWYLIeMBy0FwMU EtP4M/xrOgZkWXueBFn8StPgzPRM/CGZ7j84ZVX6LyqCzlKHx7haV0m/zfpiK+d2 Utpj/XL399Kant27dhwYmfVATeoJriPYlMunS1r/+oKgcavixWHQxpXadvUj4rOh GbbMf6mR4Vk/mxAdX/1z1FyhjsHZ7b+GSICNmGKewIkQQbFWGW17nlfE97JAGCyP CZ41FogURCfbxFb5W0ZCXR/4c299cZEER4VH2Hgc16Sx+4IMqXE= =Z7jC -----END PGP SIGNATURE----- --yEPQxsgoJgBvi8ip--