From: Zhang Chen <chen.zhang@intel.com >
To: Jason Wang <jasowang@redhat.com>, qemu-dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <chen.zhang@intel.com>, "Rao, Lei" <lei.rao@intel.com>,
Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH 03/10] Reduce the time of checkpoint for COLO
Date: Wed, 14 Oct 2020 15:25:49 +0800 [thread overview]
Message-ID: <20201014072555.12515-4-chen.zhang@intel.com> (raw)
In-Reply-To: <20201014072555.12515-1-chen.zhang@intel.com>
From: "Rao, Lei" <lei.rao@intel.com>
we should set ram_bulk_stage to false after ram_state_init,
otherwise the bitmap will be unused in migration_bitmap_find_dirty.
all pages in ram cache will be flushed to the ram of secondary guest
for each checkpoint.
Signed-off-by: leirao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
---
migration/ram.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 433489d633..9cfac3d9ba 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3009,6 +3009,18 @@ static void decompress_data_with_multi_threads(QEMUFile *f,
qemu_mutex_unlock(&decomp_done_lock);
}
+ /*
+ * we must set ram_bulk_stage to false, otherwise in
+ * migation_bitmap_find_dirty the bitmap will be unused and
+ * all the pages in ram cache wil be flushed to the ram of
+ * secondary VM.
+ */
+static void colo_init_ram_state(void)
+{
+ ram_state_init(&ram_state);
+ ram_state->ram_bulk_stage = false;
+}
+
/*
* colo cache: this is for secondary VM, we cache the whole
* memory of the secondary VM, it is need to hold the global lock
@@ -3052,7 +3064,7 @@ int colo_init_ram_cache(void)
}
}
- ram_state_init(&ram_state);
+ colo_init_ram_state();
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2020-10-14 7:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 7:25 [PATCH 00/10] COLO project queued patches 20-Oct Zhang Chen
2020-10-14 7:25 ` [PATCH 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Zhang Chen
2020-10-14 7:25 ` [PATCH 02/10] Optimize seq_sorter function for colo-compare Zhang Chen
2020-10-15 11:06 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` Zhang Chen [this message]
2020-10-14 12:16 ` [PATCH 03/10] Reduce the time of checkpoint for COLO Zhang, Chen
2020-10-14 7:25 ` [PATCH 04/10] Fix the qemu crash when guest shutdown in COLO mode Zhang Chen
2020-10-14 7:25 ` [PATCH 05/10] colo-compare: fix missing compare_seq initialization Zhang Chen
2020-10-15 11:09 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 06/10] colo-compare: check mark in mutual exclusion Zhang Chen
2020-10-14 7:25 ` [PATCH 07/10] net/colo-compare.c: Fix compare_timeout format issue Zhang Chen
2020-10-15 11:11 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 08/10] net/colo-compare.c: Change the timer clock type Zhang Chen
2020-10-15 11:14 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 09/10] net/colo-compare.c: Add secondary old packet detection Zhang Chen
2020-10-15 7:55 ` [PATCH 00/10] COLO project queued patches 20-Oct Jason Wang
2020-10-15 7:58 ` Zhang, Chen
2020-10-16 2:23 ` Jason Wang
2020-10-16 5:22 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014072555.12515-4-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=lei.rao@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).