From: Zhang Chen <chen.zhang@intel.com >
To: Jason Wang <jasowang@redhat.com>, qemu-dev <qemu-devel@nongnu.org>
Cc: Zhang Chen <chen.zhang@intel.com>, Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH 08/10] net/colo-compare.c: Change the timer clock type
Date: Wed, 14 Oct 2020 15:25:54 +0800 [thread overview]
Message-ID: <20201014072555.12515-9-chen.zhang@intel.com> (raw)
In-Reply-To: <20201014072555.12515-1-chen.zhang@intel.com>
From: Zhang Chen <chen.zhang@intel.com>
The virtual clock only runs during the emulation. It stops
when the virtual machine is stopped.
The host clock should be used for device models that emulate accurate
real time sources. It will continue to run when the virtual machine
is suspended. COLO need to know the host time here.
Reported-by: Derek Su <dereksu@qnap.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
net/colo-compare.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index f4814c5f09..61c95fe7e9 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -899,7 +899,7 @@ static void check_old_packet_regular(void *opaque)
/* if have old packet we will notify checkpoint */
colo_old_packet_check(s);
- timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
+ timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) +
s->expired_scan_cycle);
}
@@ -933,10 +933,10 @@ static void colo_compare_timer_init(CompareState *s)
{
AioContext *ctx = iothread_get_aio_context(s->iothread);
- s->packet_check_timer = aio_timer_new(ctx, QEMU_CLOCK_VIRTUAL,
+ s->packet_check_timer = aio_timer_new(ctx, QEMU_CLOCK_HOST,
SCALE_MS, check_old_packet_regular,
s);
- timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
+ timer_mod(s->packet_check_timer, qemu_clock_get_ms(QEMU_CLOCK_HOST) +
s->expired_scan_cycle);
}
--
2.17.1
next prev parent reply other threads:[~2020-10-14 7:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 7:25 [PATCH 00/10] COLO project queued patches 20-Oct Zhang Chen
2020-10-14 7:25 ` [PATCH 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Zhang Chen
2020-10-14 7:25 ` [PATCH 02/10] Optimize seq_sorter function for colo-compare Zhang Chen
2020-10-15 11:06 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 03/10] Reduce the time of checkpoint for COLO Zhang Chen
2020-10-14 12:16 ` Zhang, Chen
2020-10-14 7:25 ` [PATCH 04/10] Fix the qemu crash when guest shutdown in COLO mode Zhang Chen
2020-10-14 7:25 ` [PATCH 05/10] colo-compare: fix missing compare_seq initialization Zhang Chen
2020-10-15 11:09 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 06/10] colo-compare: check mark in mutual exclusion Zhang Chen
2020-10-14 7:25 ` [PATCH 07/10] net/colo-compare.c: Fix compare_timeout format issue Zhang Chen
2020-10-15 11:11 ` Philippe Mathieu-Daudé
2020-10-14 7:25 ` Zhang Chen [this message]
2020-10-15 11:14 ` [PATCH 08/10] net/colo-compare.c: Change the timer clock type Philippe Mathieu-Daudé
2020-10-14 7:25 ` [PATCH 09/10] net/colo-compare.c: Add secondary old packet detection Zhang Chen
2020-10-15 7:55 ` [PATCH 00/10] COLO project queued patches 20-Oct Jason Wang
2020-10-15 7:58 ` Zhang, Chen
2020-10-16 2:23 ` Jason Wang
2020-10-16 5:22 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014072555.12515-9-chen.zhang@intel.com \
--to=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).