From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, alex.bennee@linaro.org, peter.maydell@linaro.org
Subject: [PATCH 3/7] tests: add missing generated sources to testqapi
Date: Wed, 14 Oct 2020 09:54:12 -0400 [thread overview]
Message-ID: <20201014135416.1290679-4-pbonzini@redhat.com> (raw)
In-Reply-To: <20201014135416.1290679-1-pbonzini@redhat.com>
Ninja notices them due to a different order in visiting the graph.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/include/meson.build | 8 ++++----
tests/meson.build | 14 ++++++++++++--
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/tests/include/meson.build b/tests/include/meson.build
index fea3a6342f..9abba308fa 100644
--- a/tests/include/meson.build
+++ b/tests/include/meson.build
@@ -10,7 +10,7 @@ test_qapi_outputs_extra = [
'test-qapi-visit-sub-module.h',
]
-test_qapi_outputs_extra = custom_target('QAPI test (include)',
- output: test_qapi_outputs_extra,
- input: test_qapi_files,
- command: 'true')
+test_qapi_files_extra = custom_target('QAPI test (include)',
+ output: test_qapi_outputs_extra,
+ input: test_qapi_files,
+ command: 'true')
diff --git a/tests/meson.build b/tests/meson.build
index bf47a38c74..afeb6be689 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -56,8 +56,18 @@ test_qapi_files = custom_target('Test QAPI files',
# perhaps change qapi_gen to replace / with _, like Meson itself does?
subdir('include')
-libtestqapi = static_library('testqapi', sources: [test_qapi_files, genh, test_qapi_outputs_extra])
-testqapi = declare_dependency(link_with: libtestqapi)
+test_qapi_sources = []
+test_qapi_headers = []
+i = 0
+foreach o: test_qapi_files.to_list() + test_qapi_files_extra.to_list()
+ if o.full_path().endswith('.h')
+ test_qapi_headers += o
+ endif
+ test_qapi_sources += o
+endforeach
+
+libtestqapi = static_library('testqapi', sources: [genh, test_qapi_sources])
+testqapi = declare_dependency(link_with: libtestqapi, sources: [genh, test_qapi_headers])
testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
--
2.26.2
next prev parent reply other threads:[~2020-10-14 13:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:54 [PATCH 0/7] build: replace ninjatool with ninja Paolo Bonzini
2020-10-14 13:54 ` [PATCH 1/7] tests/Makefile.include: unbreak non-tcg builds Paolo Bonzini
2020-10-14 16:26 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 2/7] make: run shell with pipefail Paolo Bonzini
2020-10-14 16:27 ` Daniel P. Berrangé
2020-10-14 13:54 ` Paolo Bonzini [this message]
2020-10-14 16:27 ` [PATCH 3/7] tests: add missing generated sources to testqapi Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 4/7] configure: move QEMU_INCLUDES to meson Paolo Bonzini
2020-10-14 16:28 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools Paolo Bonzini
2020-10-14 16:33 ` Daniel P. Berrangé
2020-10-14 20:49 ` Cleber Rosa
2020-10-15 6:36 ` Paolo Bonzini
2020-10-14 13:54 ` [PATCH 6/7] add ninja to dockerfiles, CI configurations and test VMs Paolo Bonzini
2020-10-14 16:36 ` Daniel P. Berrangé
2020-10-15 6:50 ` Alex Bennée
2020-10-14 13:54 ` [PATCH 7/7] build: replace ninjatool with ninja Paolo Bonzini
2020-10-14 16:38 ` Daniel P. Berrangé
2020-10-14 13:57 ` [PATCH 0/7] " Peter Maydell
2020-10-15 6:15 ` Howard Spoelstra
2020-10-15 6:34 ` Paolo Bonzini
2020-10-15 7:39 ` Howard Spoelstra
2020-10-15 9:44 ` Paolo Bonzini
2020-10-15 17:39 ` Volker Rümelin
2020-10-15 18:49 ` Mark Cave-Ayland
2020-10-15 21:41 ` Paolo Bonzini
2020-10-16 9:35 ` Mark Cave-Ayland
2020-10-15 23:07 ` Howard Spoelstra
2020-10-15 18:21 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014135416.1290679-4-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).