From: Cleber Rosa <crosa@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: alex.bennee@linaro.org, berrange@redhat.com,
qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools
Date: Wed, 14 Oct 2020 16:49:50 -0400 [thread overview]
Message-ID: <20201014204950.GA1203215@localhost.localdomain> (raw)
In-Reply-To: <20201014135416.1290679-6-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Wed, Oct 14, 2020 at 09:54:14AM -0400, Paolo Bonzini wrote:
> ninja is included in the CentOS PowerTools repository.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/dockerfiles/centos8.docker | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
> index 0fc2697491..e31d366fc1 100644
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -1,6 +1,9 @@
> FROM centos:8.1.1911
>
> +RUN dnf -y install dnf-plugins-core
> +RUN dnf config-manager --set-enabled PowerTools
Since config-manager won't be used besides here, I think it's safe and
cheaper to simply do:
RUN sed -i /etc/yum.repos.d/CentOS-PowerTools.repo -e 's/^enabled=0/enabled=1/'
It's also a single command, reducing the number of layers.
- Cleber.
> RUN dnf -y update
> +
> ENV PACKAGES \
> SDL-devel \
> bzip2 \
> --
> 2.26.2
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-14 20:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:54 [PATCH 0/7] build: replace ninjatool with ninja Paolo Bonzini
2020-10-14 13:54 ` [PATCH 1/7] tests/Makefile.include: unbreak non-tcg builds Paolo Bonzini
2020-10-14 16:26 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 2/7] make: run shell with pipefail Paolo Bonzini
2020-10-14 16:27 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 3/7] tests: add missing generated sources to testqapi Paolo Bonzini
2020-10-14 16:27 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 4/7] configure: move QEMU_INCLUDES to meson Paolo Bonzini
2020-10-14 16:28 ` Daniel P. Berrangé
2020-10-14 13:54 ` [PATCH 5/7] dockerfiles: enable Centos 8 PowerTools Paolo Bonzini
2020-10-14 16:33 ` Daniel P. Berrangé
2020-10-14 20:49 ` Cleber Rosa [this message]
2020-10-15 6:36 ` Paolo Bonzini
2020-10-14 13:54 ` [PATCH 6/7] add ninja to dockerfiles, CI configurations and test VMs Paolo Bonzini
2020-10-14 16:36 ` Daniel P. Berrangé
2020-10-15 6:50 ` Alex Bennée
2020-10-14 13:54 ` [PATCH 7/7] build: replace ninjatool with ninja Paolo Bonzini
2020-10-14 16:38 ` Daniel P. Berrangé
2020-10-14 13:57 ` [PATCH 0/7] " Peter Maydell
2020-10-15 6:15 ` Howard Spoelstra
2020-10-15 6:34 ` Paolo Bonzini
2020-10-15 7:39 ` Howard Spoelstra
2020-10-15 9:44 ` Paolo Bonzini
2020-10-15 17:39 ` Volker Rümelin
2020-10-15 18:49 ` Mark Cave-Ayland
2020-10-15 21:41 ` Paolo Bonzini
2020-10-16 9:35 ` Mark Cave-Ayland
2020-10-15 23:07 ` Howard Spoelstra
2020-10-15 18:21 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014204950.GA1203215@localhost.localdomain \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).