* [PATCH] configure: fix handling of --docdir parameter
@ 2020-10-15 19:02 Bruce Rogers
2020-10-15 19:06 ` Bruce Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Rogers @ 2020-10-15 19:02 UTC (permalink / raw)
To: qemu-devel; +Cc: richard.henderson, laurent, Bruce Rogers
Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the
qemu_docdir name in the final assignment. Unfortunately, one instance of
qemu_docdir was missed: the one which comes from the --docdir parameter.
This patch restores the proper handling of the --docdir parameter.
Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
directories")
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index f839c2a557..07acd01a25 100755
--- a/configure
+++ b/configure
@@ -971,7 +971,7 @@ for opt do
;;
--with-suffix=*) qemu_suffix="$optarg"
;;
- --docdir=*) qemu_docdir="$optarg"
+ --docdir=*) docdir="$optarg"
;;
--sysconfdir=*) sysconfdir="$optarg"
;;
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] configure: fix handling of --docdir parameter
2020-10-15 19:02 [PATCH] configure: fix handling of --docdir parameter Bruce Rogers
@ 2020-10-15 19:06 ` Bruce Rogers
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Rogers @ 2020-10-15 19:06 UTC (permalink / raw)
To: qemu-devel; +Cc: richard.henderson, laurent
On Thu, 2020-10-15 at 13:02 -0600, Bruce Rogers wrote:
> Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses
> the
> qemu_docdir name in the final assignment. Unfortunately, one instance
> of
> qemu_docdir was missed: the one which comes from the --docdir
> parameter.
> This patch restores the proper handling of the --docdir parameter.
>
> Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
> directories")
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index f839c2a557..07acd01a25 100755
> --- a/configure
> +++ b/configure
> @@ -971,7 +971,7 @@ for opt do
> ;;
> --with-suffix=*) qemu_suffix="$optarg"
> ;;
> - --docdir=*) qemu_docdir="$optarg"
> + --docdir=*) docdir="$optarg"
> ;;
> --sysconfdir=*) sysconfdir="$optarg"
> ;;
Oops! I got the wrong CC's put on this. Let me resend with the right
interested parties. Sorry for the noise.
- Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] configure: fix handling of --docdir parameter
@ 2020-10-15 19:07 Bruce Rogers
2020-10-15 19:50 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Rogers @ 2020-10-15 19:07 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, Bruce Rogers, pbonzini
Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the
qemu_docdir name in the final assignment. Unfortunately, one instance of
qemu_docdir was missed: the one which comes from the --docdir parameter.
This patch restores the proper handling of the --docdir parameter.
Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
directories")
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index f839c2a557..07acd01a25 100755
--- a/configure
+++ b/configure
@@ -971,7 +971,7 @@ for opt do
;;
--with-suffix=*) qemu_suffix="$optarg"
;;
- --docdir=*) qemu_docdir="$optarg"
+ --docdir=*) docdir="$optarg"
;;
--sysconfdir=*) sysconfdir="$optarg"
;;
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] configure: fix handling of --docdir parameter
2020-10-15 19:07 Bruce Rogers
@ 2020-10-15 19:50 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-15 19:50 UTC (permalink / raw)
To: Bruce Rogers, qemu-devel; +Cc: marcandre.lureau, pbonzini
On 10/15/20 9:07 PM, Bruce Rogers wrote:
> Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the
> qemu_docdir name in the final assignment. Unfortunately, one instance of
> qemu_docdir was missed: the one which comes from the --docdir parameter.
> This patch restores the proper handling of the --docdir parameter.
>
> Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
> directories")
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-15 19:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-15 19:02 [PATCH] configure: fix handling of --docdir parameter Bruce Rogers
2020-10-15 19:06 ` Bruce Rogers
-- strict thread matches above, loose matches on Subject: below --
2020-10-15 19:07 Bruce Rogers
2020-10-15 19:50 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).