From: David Gibson <david@gibson.dropbear.id.au>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-ppc <qemu-ppc@nongnu.org>,
"qemu-devel qemu-devel" <qemu-devel@nongnu.org>,
"Howard Spoelstra" <hsp.cat7@gmail.com>
Subject: Re: [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs
Date: Sat, 17 Oct 2020 17:20:00 +1100 [thread overview]
Message-ID: <20201017062000.GA285896@yekko.fritz.box> (raw)
In-Reply-To: <67efe378-7979-9a51-7c66-8d8c3f55e335@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Fri, Oct 16, 2020 at 07:53:10AM +0100, Mark Cave-Ayland wrote:
> On 16/10/2020 07:45, Howard Spoelstra wrote:
>
> > Hi,
> >
> > I see compilation of the current ppc-for-5.2 branch fail with:
> >
> > ../hw/pci-host/grackle.c: In function ‘grackle_realize’:
> > ../hw/pci-host/grackle.c:68:11: error: ‘GrackleState’ has no member named ‘pic’
> > 68 | if (!s->pic) {
> > | ^~
> > make: *** [Makefile.ninja:1741: libcommon.fa.p/hw_pci-host_grackle.c.o] Error 1
> >
> > Best,
> > Howard
>
> I see - as per the cover letter, my series is a replacement for Phil's
> original patch at
> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02988.html (the PIC
> link is now completely removed), so the solution here is to drop patch
> 7daac97 "hw/pci-host/grackle: Verify PIC link is properly set".
Ok, I've removed that from my ppc-for-5.2 tree.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-10-17 6:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 11:49 [PATCH v2 0/3] ppc: Mac machine updates Mark Cave-Ayland
2020-10-13 11:49 ` [PATCH v2 1/3] macio: don't reference serial_hd() directly within the device Mark Cave-Ayland
2020-10-16 0:16 ` David Gibson
2020-10-16 7:00 ` Mark Cave-Ayland
2020-10-17 6:21 ` David Gibson
2020-10-13 11:49 ` [PATCH v2 2/3] grackle: use qdev gpios for PCI IRQs Mark Cave-Ayland
2020-10-13 13:37 ` Philippe Mathieu-Daudé
2020-10-13 16:51 ` Mark Cave-Ayland
2020-10-13 17:05 ` BALATON Zoltan via
2020-10-15 19:42 ` Mark Cave-Ayland
2020-10-16 0:26 ` BALATON Zoltan via
2020-10-17 13:03 ` Mark Cave-Ayland
2020-10-16 0:18 ` David Gibson
2020-10-16 6:45 ` Howard Spoelstra
2020-10-16 6:53 ` Mark Cave-Ayland
2020-10-17 6:20 ` David Gibson [this message]
2020-10-13 11:49 ` [PATCH v2 3/3] uninorth: " Mark Cave-Ayland
2020-10-13 13:38 ` BALATON Zoltan via
2020-10-13 16:58 ` Mark Cave-Ayland
2020-10-13 17:10 ` BALATON Zoltan via
2020-10-16 0:30 ` David Gibson
2020-10-13 13:39 ` Philippe Mathieu-Daudé
2020-10-16 0:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201017062000.GA285896@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=hsp.cat7@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).